Hashing of sg, sh, g_n and g_h not necessary

Zerocoin / libzerocoin

Zerocoin: C++ lib for anonymous extension to bitcoin

http://zerocoin.org/

MIT License

177 stars 53 forks source link

Hashing of sg, sh, g_n and g_h not necessary #8

Open jhasse opened 11 years ago

jhasse commented 11 years ago

I'm not 100% sure, but isn't the hashing of sg, sh, g_h and g_h redundant since they are also part of *params?

I've also added const to some values in the proof (makes it a little bit clearer IMHO).

I also noticed that

bool result = false;

isn't needed and it's possible to directly return with the result.

imichaelmiers commented 11 years ago

This looks about right. We have a paper deadline on the 5th so until then I don't want to mess with it, least it turn out it was something critical. Thanks

jhasse commented 11 years ago

Any news about the paper? :)