search

Zerthox / BetterDiscord-Plugins

Plugins for BetterDiscord.
MIT License
158 stars 86 forks source link

After setting another user's volume to 400 and restarting Discord, said user's volume is set to -56.66 #177

Open lynyx23 opened 8 months ago

lynyx23 commented 8 months ago

Bug description

After setting another user's volume to 400 and restarting Discord, said user's volume is set to -56.66. Sometimes this continues to default to -56.66 even after setting the volume to a different value. Resetting the plugins settings and restarting seems to fix it.

I'd be happy to send any logs or something of sorts if it's possible/needed.

Plugin

BetterVolume

Plugin version

v2.5.0

Discord client

Stable

weedsnorkeler commented 7 months ago

this has been happening to me but not when i restart discord just a few seconds after i set their volume above 200. fixes when i restart as well.

Zerthox commented 7 months ago

Technically a duplicate of #151, just that Discord's behavior with volumes above the 200% cap has changed. Looking into a workaround to still allow higher volumes.

MrBoringCom commented 4 months ago

The bug is still happening to this day and i cannot check the discord audio experiment. Is there a code that I can enable it?

HimeTakamura commented 3 months ago

Having the same issue. Trying to set anyone to over 200 will reset to negatives after a second or so.

Pittssburgh commented 2 months ago

The bug is still happening to this day and i cannot check the discord audio experiment. Is there a code that I can enable it?

In the plugin folger you see a config file - There you can set the value to true or false manually ;) Hope Im not too late haha

Pittssburgh commented 2 months ago

I experience the same issue without any possible way of fixing it

californiacryptid commented 2 months ago

Same issue here, can't fix it either.

Reenuip commented 2 months ago

Not sure if this really helped, but I was getting annoyed with someone's extremely low stream audio and decided to set the volume to something ridiculous like 99999%. Funny thing is that the volume didn't drop to some negative number or change at all. After that point, I was able to set a more reasonable volume over 200% without it changing automatically. Right now, I'm in the middle of something so I can't test much further, but maybe this is a decent workaround for the time being. Anyone else have luck trying this?

AgentAvis commented 2 months ago

@Reenuip That surprisingly appears to have worked for me too! thanks, it's nice to have a workaround.

rom4ster commented 2 months ago

Not sure if this really helped, but I was getting annoyed with someone's extremely low stream audio and decided to set the volume to something ridiculous like 99999%. Funny thing is that the volume didn't drop to some negative number or change at all. After that point, I was able to set a more reasonable volume over 200% without it changing automatically. Right now, I'm in the middle of something so I can't test much further, but maybe this is a decent workaround for the time being. Anyone else have luck trying this?

so it appears to work, but did you actually notice any audible audio change?

I think this is just braking an api calll?

Reenuip commented 2 months ago

so it appears to work, but did you actually notice any audible audio change?

I think this is just braking an api calll?

Yeah, it definitely changes the volume for me. I have a hard time hearing my buddies' streams, so having this add-on work is essential.

rom4ster commented 2 months ago

so it appears to work, but did you actually notice any audible audio change? I think this is just braking an api calll?

Yeah, it definitely changes the volume for me. I have a hard time hearing my buddies' streams, so having this add-on work is essential.

the absolute monkeys at discord should have made this feature, I truly despise them. So its good to hear it works but it also seems to reset everytime u start discord.

pickanothername commented 2 months ago

It seems that this is fixed in v3.0.0. Thank you!!

rom4ster commented 2 months ago

im on 3.0.0 and its not fixed. Still does this garbage.

Zerthox commented 2 months ago

im on 3.0.0 and its not fixed. Still does this garbage.

Try enabling the addon after Discord loads. There seems to be a problem with a part of BetterDiscord's plugin API that makes the plugin miss some information it needs. If it still doesn't work, it would be helpful to know what's being logged to the console (Ctrl+Shift+I).

rom4ster commented 2 months ago

discord.com-1724532883810.log

This is my log. Could u try maybe making it so calls to https://discord.com/api/v9/users/@me/settings-proto/1 are blocked for a little bit after the user changes the setting?

It is definetly something with that call. Weather its before the call is made or the call itself though idk.

Also its unfeasible to remember to turn the plugin on AND TURN IT OFF when im done using it. Becuase if i dont, on next boot it will do the same behavior.

Zerthox commented 2 months ago

The log is incomplete, I can't tell what went wrong without the plugin start being part of it. Did you try what I wrote above?

GoldenLumia commented 2 months ago

im on 3.0.0 and its not fixed. Still does this garbage.

Try enabling the addon after Discord loads. There seems to be a problem with a part of BetterDiscord's plugin API that makes the plugin miss some information it needs. If it still doesn't work, it would be helpful to know what's being logged to the console (Ctrl+Shift+I).

This works for me, as simple as disabling and enabling the plugin again.