Reminder having false positives

[Zerthox]

Due events reported by Arc being out of order sometimes, the plugin might receive an event that fits the current criteria of having a later timestamp than initial buff events before all initial buff events have been received. This may lead to a false positive.

In order to fix this, the plugin would have to either put out of order events in a queue, which would essentially be sequentializing the whole thing. Or it could keep track of event ids (in a sorted vector or btree set?) and only trigger a reminder when it is certain all initial buff events have been received.

[Zerthox]

Tracking event ids does not work out since Arc delays or skips events. Forcing sequential processing most likely also wont work since the plugin has no idea when it has to wait for an older event and when Arc simply will not report it.

[Zerthox]

The minimum time difference to last buff initial event added in https://github.com/Zerthox/arcdps-food-reminder/commit/130aabd4e9066be4fa5dcb34f5d7809de92f396a should reduce the chances of false positives. A guaranteed fix seems impossible.

[Zerthox]

It seems like an increased number of false positives on encounter start are occuring with more recent versions of ArcDPS. Need to look into whether something related to buff initial events changed.