search

Zerthox / arcdps-food-reminder

ArcDPS plugin for Guild Wars 2 allowing tracking of buff food & utility items.
MIT License
16 stars 3 forks source link

Incorrect Reinforced Armor buff state #27

Closed AdjutantAvocado closed 1 year ago

AdjutantAvocado commented 2 years ago

As of release v0.5.1, the reinforced armor column is indicated as a red "No" if the player doesn't need to refresh their Reinforced buff. That's kind of counterintuitive, I'd suggest changing it to a green "On" and red "Off", or green "Active" and red "Inactive".

AdjutantAvocado commented 2 years ago

clarification: out of combat only

Zerthox commented 2 years ago

The red "No" should be displayed when the Reinforced Armor buff is not applied to the player and the green "Yes" when it is applied. If "No" is displayed while the player has the Reinforced buff something went wrong.

Zerthox commented 1 year ago

Identified the issue. Refreshing Reinforced could apply the new buff before removing the old one, which caused the plugin to incorrectly think there was no Reinforced present on the player. Should be fixed in the next update.

Stefanovicc commented 1 year ago

Identified the issue. Refreshing Reinforced could apply the new buff before removing the old one, which caused the plugin to incorrectly think there was no Reinforced present on the player. Should be fixed in the next update.

I'm still getting the message "Reinforced reminder!" even though I have the buff on. Am I doing something wrong?

Zerthox commented 1 year ago

I'm still getting the message "Reinforced reminder!" even though I have the buff on. Am I doing something wrong?

What does the tracker window display? Default hotkey is Alt+Shift+F.

If it says Reinforced is not applied, check the log window: ArcDPS settings (Alt+Shift+T), About tab, click the log checkbox. Under extensions you should be able to see the buff apply & remove events registered by the plugin.

Stefanovicc commented 1 year ago

I'm still getting the message "Reinforced reminder!" even though I have the buff on. Am I doing something wrong?

What does the tracker window display? Default hotkey is Alt+Shift+F.

If it says Reinforced is not applied, check the log window: ArcDPS settings (Alt+Shift+T), About tab, click the log checkbox. Under extensions you should be able to see the buff apply & remove events registered by the plugin.

Thanks for your reply.

I've just checked it. It says "YES" in the food tracker, but when I enter combat it changes to "NO" (while it's still active). Therefore it shows "After encounter" & "During encounter" that it's missing.

Here the log: https://i.gyazo.com/035f97992db110f9bc2e99508965cd4d.jpg Last line is when going out of combat, the one before is when going in combat

Zerthox commented 1 year ago

The log gives the impression Arc is delaying the buff apply in the plugin API until log end. But I am unable to reproduce this. Which ArcDPS version are you on?

Stefanovicc commented 1 year ago

The log gives the impression Arc is delaying the buff apply in the plugin API until log end. But I am unable to reproduce this. Which ArcDPS version are you on?

Hmm weird. This is my version: arcdps 20220914.180323-454-x64