ZeruLight / Erupe

Monster Hunter Frontier Server Emulator
https://discord.gg/DnwcpXM488
MIT License
200 stars 53 forks source link

Raviente Support Deliveries not working as intended #90

Closed ghost closed 1 year ago

ghost commented 1 year ago

Description: When playing Support during a Great Slaying, the sedation/resurrection support deliveries do not work as intended.

Reproduction Steps:

  1. Sedation support is requested, the first 50 Tranquilizers are delivered, and sedation support is carried out.
  2. Sedation support is requested a 2nd time, but the total tranquilizers delivered stays over 50 and delivering additional increments of 50 does not resend sedation support at all.
  3. Even different types of support such as resurrection support delivery do not work as intended after the first delivery.

Screenshots mhf_gfBOAVQ556 mhf_cZwxVom4zV

Additional context Based on the footage below, the counter for Tranquilizers, etc. delivered should be reset once support has been successfully carried out and is requested again: https://youtu.be/grE1Mn7eEKM?si=BLjRHwa3-cdJJZaB&t=1862

Please let me know if any additional data is needed.

sekaiwish commented 1 year ago

This affected all versions (not just Forward.5) but only when using simplified Support (Normal and Violent Raviente). I fixed and simplified the code used for this in https://github.com/ZeruLight/Erupe/commit/0f2edbf0286d97e74c7359f78df032e31859c7ae. Can you verify that the commit applied fixes the issues? Thanks.

ghost commented 1 year ago

Thanks for looking into this Wish, the soonest I'll be able to test this is Friday evening but I will test it then and report back!

ghost commented 1 year ago

I tested with another person the new commit,

Screenshots below are from after the first support delivery is carried out; tested on normal Ravi - support deliveries work as intended (counter resets upon subsequent deliveries and support is always carried out successfully:

mhf_MZdgUOPlvS mhf_bJ2eKsE4eR vlc_k7mcg3R1gQ mhf_fsq3aT3scK

Thank you once more for investigating and fixing this, Wish!