search

Zeruell / ppx-raidplaner

Automatically exported from code.google.com/p/ppx-raidplaner
0 stars 0 forks source link

Banner is cut on low res screens #26

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?

1. Change resolution to somthing like 1366x768 (it's my resolution and most of 
laptops)
2. Open raidplanner

What is the expected output? What do you see instead?

Page should start from the top of the banner.
Instead banner is cut in half.

What version of the product are you using? On what operating system?

0.97, Google Chrome, Win 7

Please provide any additional information below.

main.css in Layout folder contains banner negative margin. Isuppose it's used 
center raidplanner (moving banner a little higher) on bigger screens. 
Unfortunately on screens with 768 height it's cut in half.

Possible solutions would be reworking this part or give an option to disable 
banner in settings (I disabled it anyway becouse with banner raidplanner needs 
scrolling).

Original issue reported on code.google.com by Osipi...@gmail.com on 8 Mar 2013 at 1:22

Attachments:

GoogleCodeExporter commented 9 years ago 
Yes, this happens because the raidplaner is centered to the screen and it only 
happens if the document window's vertical space is less than 768px.

This is actually a rather tricky thing to fix as the vertical space depends on 
how a browser is configured. Opera for example has these large tabs which may 
reduce the screen space to about 600px on 1024x768. And don't get me started 
about toolbars.
Furthermore - if I target lower resolutions the layout will probably feel too 
small on larger screens.

A cut-in-half banner is certainly not pretty, yes, but its more important to 
see everything of the content area (which is not the case here).
So scrolling and not seeing parts of the banner is perfectly ok as long as you 
see as much as possible of the content area.

As of this I imagine the following (quick) fix:
If the screen space is below 768px the page gets scrolled down until the top 
line of the menu is still visible. It stops early once the bottom line of the 
content area becomes visible.
This means you may see parts of the banner but the content area will be fully 
visible. If there is not enough space for the content area (somewhere below 
600px), the page starts with the menu and you may have to scroll manually.

A more sophisticated fix would be to use an auto-resizing layout but I have no 
idea how much time this will take to implement (or if it's possible at all)

As for an option to disable the banner.
I will include that into 0.9.8.

Original comment by arne.cl...@gmail.com on 8 Mar 2013 at 2:44

GoogleCodeExporter commented 9 years ago 
Disabling the banner and putting the appwindow in the top left corner will be 
part of 0.9.7a and is already committed to the trunk.
Fixing the cut-off banner (by scrolling) will be included later this week, too.

Original comment by arne.cl...@gmail.com on 12 Mar 2013 at 8:53

GoogleCodeExporter commented 9 years ago

Original comment by arne.cl...@gmail.com on 16 Mar 2013 at 6:12