[Feature request] Default role for class

[GoogleCodeExporter]

What steps will reproduce the problem?

1. Make custom role (for example split damage to melee and ranged)
2. Create new character

What is the expected output? What do you see instead?

Default role should match selected class. Now its always melee in my example.

What version of the product are you using? On what operating system?

0.97

Please provide any additional information below.

It's only convenience upgrade to be able to set default role to each class for 
example for other games.
It could be an enum or table with class/default role fields in the 
customization file.
Usage in my example would be to set default melee for Rogue, ranged for Mage 
etc.

Original issue reported on code.google.com by Osipi...@gmail.com on 8 Mar 2013 at 4:50

[GoogleCodeExporter]

Hmm ... I'm not quite sure about the details, but I'll try to add this to 0.9.8

Original comment by arne.cl...@gmail.com on 8 Mar 2013 at 7:11

• Changed state: Accepted
• Added labels: FixScheduledFor-0.9.8, Found-0.9.7

[GoogleCodeExporter]

Original comment by arne.cl...@gmail.com on 8 Mar 2013 at 7:13

• Added labels: Type-Feature
• Removed labels: Type-Defect

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Actually this issue is a bug, not a feature :D
The code was there but it was targeting wrong DOM element.

FIX in attachment as a diff.
Also included sample "gameconfig.php" file for testing.

After this fix if you change the class the first role from roles table is 
choosen and applyed to both roles of that character.

Original comment by Osipi...@gmail.com on 19 Mar 2013 at 8:32

Attachments:

• gameconfig.php
• tooltip.js.diff

[GoogleCodeExporter]

Hmm ... the email trigger seems to have failed for your last comment...

It's actually a little more than this, but your fix is still valid.
So - thanks - will be integrated :)

In addition to that, the 0.9.8 version will have another array field for the 
default role to be used when you select a class. This includes overwriting a 
role that has been supported by the class you previously selected but is not 
supported by the current selection and other little quirks in that area.
It's not fully implemented in the branch, yet, but that's what it will come 
down to.

Original comment by arne.cl...@gmail.com on 16 Apr 2013 at 6:21

[GoogleCodeExporter]

The fix posted above is valid for 0.9.7 (for those waiting for an "official" 
statement).
The 0.9.8 development branch contains a slightly modified version.

Original comment by arne.cl...@gmail.com on 21 Apr 2013 at 4:04

• Changed state: Done

[GoogleCodeExporter]

Original comment by arne.cl...@gmail.com on 26 May 2013 at 9:40

• Changed state: Fixed