search

Zeruell / ppx-raidplaner

Automatically exported from code.google.com/p/ppx-raidplaner
0 stars 0 forks source link

[Feature request] Setting for number of columns for selected role #29

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?

1. Make custom role (ex. split damage to melee and ranged)
2. Go to raid details

What is the expected output? What do you see instead?

I want to customize that melee and ranged are both two columns wide. Currently 
every role but last one is 1 column wide and last column take the rest of space.

What version of the product are you using? On what operating system?

0.97

Please provide any additional information below.

I changed that very easily in code but it would be nice to have that 
configurable. If i remember correctly there are like 8 rows for a role and if i 
want to set for certain raid like 9 melee and 8 ranged then melee is paged and 
ranged is almost empty... It just looks bad. I know that when i set melee and 
ranged to 2 columns it looks way better.

Original issue reported on code.google.com by Osipi...@gmail.com on 8 Mar 2013 at 5:03

GoogleCodeExporter commented 9 years ago 
Should not break anything and should be quite easy to implement.
As of this I will try to add this for 0.9.8

Original comment by arne.cl...@gmail.com on 8 Mar 2013 at 7:06

GoogleCodeExporter commented 9 years ago

Original comment by arne.cl...@gmail.com on 8 Mar 2013 at 7:11

GoogleCodeExporter commented 9 years ago 
I implemented it on clean 0.97a. Contains changed in 3 files that matches your 
style of coding (at least i hope so :D)

Diffs in attachment.

Original comment by Osipi...@gmail.com on 19 Mar 2013 at 8:18

Attachments:

GoogleCodeExporter commented 9 years ago 
Will be checked and integrated in the 0.9.8 branch.
Thanks.

Original comment by arne.cl...@gmail.com on 16 Apr 2013 at 6:22

GoogleCodeExporter commented 9 years ago 
The fix posted above is valid for 0.9.7 (for those waiting for an "official" 
statement).
The 0.9.8 development branch contains a slightly modified version.

Original comment by arne.cl...@gmail.com on 21 Apr 2013 at 4:19

GoogleCodeExporter commented 9 years ago

Original comment by arne.cl...@gmail.com on 26 May 2013 at 9:40