Large calendar date off by one

[GoogleCodeExporter]

What steps will reproduce the problem?
1. View the large Calendar
2. You'll notice the date & week day are off.

What is the expected output? What do you see instead?
Today is Sunday 26th but the weekday shows Monday 26th on the Calendar.  It's 
corrected when you double click and view the small one.  But placing the raid 
on the wrong day.

What version of the product are you using? Which browser / php version are
you using?
0.9.8 - Chrome, php(GoDaddy)

Please provide any additional information below.

Original issue reported on code.google.com by try...@gmail.com on 27 May 2013 at 1:55

Attachments:

• calendarbug.png

[GoogleCodeExporter]

A quick check on two of my test systems does not show this bug.
Did you do any modifcations?

I would also require your php version for better reproduction
(see https://code.google.com/p/ppx-raidplaner/wiki/DetailedBugReports)

Original comment by arne.cl...@gmail.com on 27 May 2013 at 5:44

• Changed state: NeedsMoreInfo

[GoogleCodeExporter]

I have no made any modifications that I'm aware of that would have changed 
this.  I placed it in an iframe but even when going to the full address it's 
the same error.  Dates are off.

I have changed the theme to Portal Integration but any other theme does the 
same.  I have attached the files you requested.

Original comment by try...@gmail.com on 27 May 2013 at 6:18

Attachments:

• phpinfo.htm
• calendar.png

[GoogleCodeExporter]

Month:5
Year:2013
Action:query_calendar
Response Headersview source
Cache-Control:no-store, no-cache, must-revalidate, post-check=0, pre-check=0
Connection:Keep-Alive
Content-Encoding:gzip
Content-Length:161
Content-Type:text/xml
Date:Mon, 27 May 2013 06:10:26 GMT
Expires:Thu, 19 Nov 1981 08:52:00 GMT
Keep-Alive:timeout=5, max=99
Pragma:no-cache
Server:Apache
Vary:Accept-Encoding

(this error below didn't happen again when i enabled all errors in my php.ini)
Console Error: Uncaught TypeError: Cannot read property '1' of null 
ph_core.js:58

Original comment by try...@gmail.com on 27 May 2013 at 6:19

[GoogleCodeExporter]

I remember I had changed one thing.  I changed it to have the start of the week 
start on Sunday.   I changed it back and it's still bugged.  Tuesday is showing 
the 27th.  Monday is the 27th.

Original comment by try...@gmail.com on 27 May 2013 at 6:26

[GoogleCodeExporter]

The whole thing is exactly one day off in your case.
There are two candidates that might cause the issue but both behave normal on 
my installations.
So it's - once again - most likely a server configuration thing (but that's 
just a guess until tested).

Original comment by arne.cl...@gmail.com on 27 May 2013 at 7:33

• Changed state: Accepted
• Added labels: FixScheduledFor-0.9.8a

[GoogleCodeExporter]

Let me know if you'd like me to reinstall it. 

Would I just delete the folder from the server and upload the new one / update?
Or should I delete the db files

Original comment by try...@gmail.com on 27 May 2013 at 7:37

[GoogleCodeExporter]

By configuration I meant server configuration not raidplaner configuration.
For example: There was an issue were the mysql server was located in another 
timezone than the webserver which lead to wrong raid dates. That's an example 
of a "server configuration issue".

So your install is fine. I just have to find out why your server is different 
from mine/others and fix that (e.g. by not using strtotime).

Original comment by arne.cl...@gmail.com on 27 May 2013 at 8:47

[GoogleCodeExporter]

Thanks, I did forget to change my timezone initially.  It was set for 
USA/Denver but I'm in Canada.  Doesn't affect the calendar or date though.

Appreciate you looking in to this one

Original comment by try...@gmail.com on 27 May 2013 at 1:52

[GoogleCodeExporter]

Please try replacing the attached file in lib/private.

Original comment by arne.cl...@gmail.com on 27 May 2013 at 6:58

• Changed title: _Large calendar date off by one _

Attachments:

• message_query_calendar.php

[GoogleCodeExporter]

I have replaced the message_query_calendar.php in lib/private with the one 
provided.

Still a day off.  

Original comment by try...@gmail.com on 27 May 2013 at 7:34

[GoogleCodeExporter]

Okay, it's not strotime. This breaks things down a bit, but there a still a few 
candidates.

Could you send me the content of a calendar XHR request?
(explained here 
https://code.google.com/p/ppx-raidplaner/wiki/DetailedBugReports)

Just open the calendar (any date) and send me the returned XML of the last 
messagehub.php.

Original comment by arne.cl...@gmail.com on 27 May 2013 at 9:41

[GoogleCodeExporter]

sure, give me a few minutes

Original comment by try...@gmail.com on 27 May 2013 at 9:42

[GoogleCodeExporter]

Hope this is what you are looking for.

Original comment by try...@gmail.com on 27 May 2013 at 9:52

Attachments:

• messagehub.php.xml

[GoogleCodeExporter]

I have attached a 2nd one.  This one is from the Large Calendar when I load the 
large calendar after logging in.  The previous one opened the small calendar 
which was ok.

Original comment by try...@gmail.com on 27 May 2013 at 10:10

Attachments:

• 2messagehub.php.xml

[GoogleCodeExporter]

Ok, when you generated that last XML, the first day shown *should* be monday 
the 29th, but you *see* monday 28th? (just asking because your last screenshot 
shows sunday as first day of the week).

Original comment by arne.cl...@gmail.com on 28 May 2013 at 5:39

[GoogleCodeExporter]

The XML says, that the first calendar entry should be 4/29 and the week starts 
on monday.
This would be correct with standard settings.

If the calendar shows something different (e.g. 4/28 as first day), the 
javascript is doing weird things.

Original comment by arne.cl...@gmail.com on 28 May 2013 at 5:52

[GoogleCodeExporter]

I noticed the same in the file.  Was going to mention it but wasn't sure I was 
viewing it correctly.

How would we go about testing / addressing this?

Original comment by try...@gmail.com on 28 May 2013 at 5:53

[GoogleCodeExporter]

Hmm so you're saying it says that it Starts on a Monday?  Would it have messed 
up when I changed the start of the week to Sunday when I configured it?  

Changing it back now is not helping.

Original comment by try...@gmail.com on 28 May 2013 at 5:56

[GoogleCodeExporter]

So when you sent me that XML your start of week was set to sunday?

Original comment by arne.cl...@gmail.com on 28 May 2013 at 6:13

[GoogleCodeExporter]

Ok, one test before I have to go to work.
This covers the scripting side, so replace the file in lib/script.
I still need to read through documentation if the changes aren't just plainly 
wrong but they might adress timezone issues on the browser side. But it fixes a 
bug when changing between years (which is broken at the moment).

Original comment by arne.cl...@gmail.com on 28 May 2013 at 6:20

Attachments:

• calendar.js

[GoogleCodeExporter]

Correct. It's set to Sunday. Changed it almost as soon as I installed it. Can't 
remember if the dates were good then. 
 
2:20am here in Ontario Canada so I'll be heading out. Please let know if 
there's anything I can try in the morning. 

Re-install?  What's the best pratice for that? Just upload a new raidplaner 
folder and run the setup again? Should I touch the db at all?
—
Sent from Mailbox for iPhone

On Tue, May 28, 2013 at 2:13 AM, null <ppx-raidplaner@googlecode.com>
wrote:

Original comment by try...@gmail.com on 28 May 2013 at 6:24

[GoogleCodeExporter]

Seems to be working now with the new calendar.js 

Thank you.  

Original comment by try...@gmail.com on 28 May 2013 at 6:28

[GoogleCodeExporter]

Okay. If that did the trick for you I'll have a look at the details of the 
fixes.
A clean "sources only" reinstall can be done this way:

- Copy everything from lib/config on your server to another location
- Delete every file in your raidplaner installation
- Copy the new release to your server
- Copy your saved configs to lib/config on your server

That's enough to "reset" the code and get rid of any old files.
The database update script works fairly well, so there is no need to reset the 
database.
If your database does not contain any vital data and you want to be extra sure:

- Remove all tables from your database (or all raidplaner tables if you've got 
a shared installation)

If you want to keep your config:
- Go to setup and run a repair
- OR use the sql dump from the download section
- Reset your admin password

If you want to reset your configs, too (aka. full reinstall)
- Delete *at least* the config.php from lib/config
- Do a reinstall (the install option only shows up if there is no config.php)

Original comment by arne.cl...@gmail.com on 28 May 2013 at 7:20

[GoogleCodeExporter]

The fixes in the calendar.js I posted are valid - for the moment.
I will check the rest of the raidplaner scripts to always use UTC for 0.9.8a.

I will add a proper timezone support for 1.0 so that players in different 
timezones will see the correct dates and times according to their location. The 
raidplaner does not support this at the moment and it's a too tricky topic to 
be included in a hotfix.

Original comment by arne.cl...@gmail.com on 28 May 2013 at 7:46

[GoogleCodeExporter]

Original comment by arne.cl...@gmail.com on 28 May 2013 at 8:54

• Changed state: Done

[GoogleCodeExporter]

Original comment by arne.cl...@gmail.com on 30 May 2013 at 1:44

• Added labels: Found-0.9.8

[GoogleCodeExporter]

Original comment by arne.cl...@gmail.com on 2 Jun 2013 at 11:22

• Changed state: Fixed