Bug: Role Slots set to 0 in Group Sizes.

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Defining group sizes where a specific role is set to 0, it reverts to a 
minimum of 1.

What is the expected output? What do you see instead?
When you set one role slot in your group to 0, it decreases the previous role 
slot by 1 when saving.

What version of the product are you using? Which browser / php version are
you using?
Version 101

Please provide any additional information below.

Original issue reported on code.google.com by matthias...@gmx.net on 17 Nov 2013 at 9:43

[GoogleCodeExporter]

Original comment by arne.cl...@gmail.com on 18 Nov 2013 at 6:21

• Changed state: Accepted
• Added labels: FixScheduledFor-1.0.3, Found-1.0.1
• Removed labels: Found-1.0.2

[GoogleCodeExporter]

The attached file removes the sanity check that a role shall have at least 1 
slot.
This enables size 0 roles that stay size 0 after making changes to a raid.

Original comment by arne.cl...@gmail.com on 1 Dec 2013 at 7:23

• Changed state: Done

Attachments:

• fix90.zip

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Thanks you. It works perfectly :)

Original comment by adfar...@gmail.com on 1 Dec 2013 at 9:21

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

After many try, if i add one role ( 4 and not 3 ), the problem appears always 
on the last role. 

The first, second & third can be at 0 but not the fourth one.

There is another problem with the number of people allowed in a role. First 
time i create a 8 raid, no pbl. The raid is slot role 1 : 2 / slot role 2 : 2 / 
slot role 3 : 4 & slot role 4 : 0. 
If i change the number of people in the raid ( exemple 24 raid who is 6/6/12/0 
); the result is on the screen : slot role 1 - 2 / slot role 2 : 2 / slot role 
3 : 4 & slot role 4 : 16

Don't know how i can fix it. If i can help you by testing a fix, feel free ton 
contact me. 

Original comment by adfar...@gmail.com on 13 Dec 2013 at 6:09

[GoogleCodeExporter]

The attached file removes another sanity check on the script side.
This fixes the recalculation when changing the role count via raid settings.

Original comment by arne.cl...@gmail.com on 14 Dec 2013 at 7:42

Attachments:

• fix90_2.zip

[GoogleCodeExporter]

Don't forget to enable script debugging in the index.php before applying fix90_2

Original comment by arne.cl...@gmail.com on 14 Dec 2013 at 7:43

[GoogleCodeExporter]

You're the boss :)
It works. 
For the first problem : the fourth role stay at 0 when i need it.
For the second problem : when i change the 8 raid in 24 raid, all the 16 slot 
available go to the 4th role but i can reassign the exact number in the first, 
second and third role ( and let's the fourth one at 0 ) so it's working :)

Thanks for the work. 

Original comment by adfar...@gmail.com on 15 Dec 2013 at 11:19

[GoogleCodeExporter]

Original comment by arne.cl...@gmail.com on 30 Dec 2013 at 6:35

• Changed state: Fixed