ZestfulNation / vue-hotel-datepicker

A VueJS v2 responsive date range picker. Displays the number of nights selected and allow several useful options like custom check-in/check-out rules, localization support and more.
https://zestfulnation.github.io/vue-hotel-datepicker/
MIT License
840 stars 220 forks source link

please update devDependencies #194

Closed mariusa closed 4 years ago

mariusa commented 4 years ago

Description

package.json > devDependencies lists some old versions, which depend on old versions themselves, which results in npm warnings

Please change to the simpler syntax, eg

"babel-runtime": "7.x.x",

Thanks

matiasperrone commented 4 years ago

Did you check the v3?

mariusa commented 4 years ago

That looks great, I wasn't aware about it. Thanks!

mariusa commented 4 years ago

Could you please publish 3.0.0 to npm? Or, how to install now?

matiasperrone commented 4 years ago

Sure thing... done!

matiasperrone commented 4 years ago

v3.0.1

mariusa commented 4 years ago

Ah, sorry, but it doesn't seem to work. npm install works, but when starting the app it gives

This dependency was not found:

* vue-hotel-datepicker in ...

To install it, you can run: npm install --save vue-hotel-datepicker

I think the cause is the dist/ folder missing. Version 2.x had it (and no source), other npm packages also have the dist/ folder.

matiasperrone commented 4 years ago

I forget to include the files in package.json so that's why it didn't work

matiasperrone commented 4 years ago

v3.0.3 is the charmed!

mariusa commented 4 years ago

Still an issue :(

To replicate:

vue create hello-world
cd hello-world/
npm install vue-hotel-datepicker --save
npm run serve

So far so good. 3.0.3 is installed. Then add to App.vue

<script>
import HelloWorld from './components/HelloWorld.vue'
import HotelDatePicker from 'vue-hotel-datepicker'

export default {
    name: 'App',
    components: {
        HelloWorld,
        HotelDatePicker,
    },
}
</script>

results in

ERROR  Failed to compile with 1 errors                                                                                                                                                                      07:16:51

This dependency was not found:

* vue-hotel-datepicker in ./node_modules/cache-loader/dist/cjs.js??ref--12-0!./node_modules/babel-loader/lib!./node_modules/cache-loader/dist/cjs.js??ref--0-0!./node_modules/vue-loader/lib??vue-loader-options!./src/App.vue?vue&type=script&lang=js&

To install it, you can run: npm install --save vue-hotel-datepicker
matiasperrone commented 4 years ago

Done, sorry build issue in package.json v3.0.5 should work now

mariusa commented 4 years ago

Hi, now there's another error using the replicate steps above:

Uncaught TypeError: Cannot read property 'call' of undefined
    at o (app.js?77f8:1)
    at Module.56d7 (app.js?77f8:1)
    at o (app.js?77f8:1)
    at Object.0 (app.js?77f8:1)
    at o (app.js?77f8:1)
    at i (app.js?77f8:1)
    at eval (app.js?77f8:1)
    at eval (app.js?77f8:1)
    at Object../node_modules/vue-hotel-datepicker/dist/js/app.js (chunk-vendors.js:1187)
    at __webpack_require__ (app.js:849)

It would be useful for you to test after release ;)