ZestfulNation / vue-hotel-datepicker

A VueJS v2 responsive date range picker. Displays the number of nights selected and allow several useful options like custom check-in/check-out rules, localization support and more.
https://zestfulnation.github.io/vue-hotel-datepicker/
MIT License
840 stars 220 forks source link

feat(styles): add prefix and default to variables #230

Closed superbiche closed 4 years ago

superbiche commented 4 years ago

This PR does a few things related to styles which seem necessary for the v4 release:

I have been too busy to finish it earlier, I'll deal with the items left in the next few days.

matiasperrone commented 4 years ago

I revised the conflicts and solved! The only issue that I've found is that the "disabledWeeksDays" is a enumeration of date's names instead of numbers relative to first day.

matiasperrone commented 4 years ago

But that is not the objective of this PR

superbiche commented 4 years ago

But that is not the objective of this PR

Yup, I guess we can keep this issue scoped to the todo list, but make an issue for the disabledWeeksDays and fix it before v4.0.0.

And thanks for resolving the conflicts !

matiasperrone commented 4 years ago

I agree! 😀

matiasperrone commented 4 years ago

I am working right now on "Prefix all classes with .vhd__ to avoid conflicts with other datepicker libraries"

matiasperrone commented 4 years ago

Some extra testing is necessary. I didn't have the time to finish testing the last bullet.

superbiche commented 4 years ago

@matiasperrone this is HUGE! Thanks so much! I'll take some time tomorrow to test this :+1:

matiasperrone commented 4 years ago

Some extra variables were introduced. But I wasn't able to solve the border of "today".

Some weird issue happens with the number when selected and hover, and out... probably some decimal error...

matiasperrone commented 4 years ago

The testing area is nicer also 😁

matiasperrone commented 4 years ago

And then before going out with the Final Release we have to be able to launch a new doc https://krystalcampioni.github.io/vue-hotel-datepicker/#moreExamples

Is the "gh-pages" branch

matiasperrone commented 4 years ago

I think that I have an idea but note sure yet.

superbiche commented 4 years ago

:tada: