search

ZestfulNation / vue-hotel-datepicker

A VueJS v2 responsive date range picker. Displays the number of nights selected and allow several useful options like custom check-in/check-out rules, localization support and more.
https://zestfulnation.github.io/vue-hotel-datepicker/
MIT License
840 stars 220 forks source link

showYear should be true by default. #232

Closed matiasperrone closed 3 years ago

matiasperrone commented 4 years ago

I think that showYear should be true by default.... makes sense.

What do you think @superbiche, @krystalcampioni ?

krystalcampioni commented 4 years ago

Sure, that makes sense! Let's just make sure to release this as breaking change 👍🏽

superbiche commented 4 years ago

@matiasperrone yup, makes sense. Let's do this before releasing v4.0.0, we can still add some breaking changes

matiasperrone commented 4 years ago

Sure... what other breaking changes there will be?

matiasperrone commented 4 years ago

I'll go with "disabled week days", now they are harcoded with the traslation as names... we could use numbers.

superbiche commented 4 years ago

I agree. These should be integers or US day names. I'd also use objects for the day/month names instead of an array, as it's a pain when coupling with Vue-i18n and a translation system (we use Weblate).

superbiche commented 4 years ago

@matiasperrone I'm creating an issue for the last steps towards v4.0.0. Could you either edit your issue or create an new one with these items (add if I'm missing some) :

I'm creating issues for the rest

matiasperrone commented 4 years ago

It is correct, the first is now corrected. I have found a "bug" value is never mutated... :(

superbiche commented 4 years ago

@matiasperrone damn... Let's make an issue of it if you will

matiasperrone commented 3 years ago

Solve in commit https://github.com/krystalcampioni/vue-hotel-datepicker/commit/82d3a644c6663bf668350fddd58a8e9c2788be9b