ZestfulNation / vue-hotel-datepicker

A VueJS v2 responsive date range picker. Displays the number of nights selected and allow several useful options like custom check-in/check-out rules, localization support and more.
https://zestfulnation.github.io/vue-hotel-datepicker/
MIT License
840 stars 220 forks source link

Use objects instead of arrays in day-names and month-names #236

Closed superbiche closed 4 months ago

superbiche commented 4 years ago

I'm using Vue-i18n and Weblate for our translation workflow.

Unfortunately, Weblate, but many other tools like dot-object or even deepmerge can have a hard time handling arrays.

We can get to the following common sense:

I honestly don't know which is best. I find the string-based one easier to read right now, but I'm pretty sure that once we change the code accordingly, integers will be much easier to work with, and allow easier props customization.

superbiche commented 4 years ago

I've added this to v4 but maybe v5 huh, this may be too much work and delay v4 without a good enough reason

matiasperrone commented 3 years ago

@superbiche What about this?

matiasperrone commented 4 months ago

So you may use Object.values or Object.entries javascript functions