search

ZestfulNation / vue-hotel-datepicker

A VueJS v2 responsive date range picker. Displays the number of nights selected and allow several useful options like custom check-in/check-out rules, localization support and more.
https://zestfulnation.github.io/vue-hotel-datepicker/
MIT License
840 stars 220 forks source link

Price format #274

Closed nathanjhastings closed 3 years ago

nathanjhastings commented 3 years ago

There was recently a change to the price format to use a number rather than a string. This works fine but it's causing an issue for us on mobile to fit the cost of stay in the space we have e.g. £423.00. This was not an issue before as we passed the string £435 as there is no need to pass the zero pence.

Would it be possible for us to implement the option of passing the price in a string format?

Happy to write a pull request if we can agree a solution.

matiasperrone commented 3 years ago

Price is in effect a String. Check the src/DatePicker/components/Price.vue component, but it is formated that way. Please PR with incorporation of a priceDecimals and the doc and I will implement that.

Line 187 of Day.vue

matiasperrone commented 3 years ago

Well already finished this... I am testing now

nathanjhastings commented 3 years ago

Great! What branch is this in?

matiasperrone commented 3 years ago

v4.4 but I will try to release a beta version in the next hours

matiasperrone commented 3 years ago

Sorry I've been extremely busy.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

matiasperrone commented 3 years ago

sorry not ready yet

matiasperrone commented 3 years ago

v4.4.2 should fix this issue with the new props