Tests are not indicative?

Zestylogic / FMark

Markdown parser to html with many useful extensions and a purely functional implementation.

https://zestylogic.github.io/FMark

MIT License

8 stars 2 forks source link

Tests are not indicative? #177

Open ps-george opened 5 years ago

ps-george commented 5 years ago

In #175, it passes CI but we aren't sure if it works live.

We should be able to gain a certain amount of confidence that a commit works from whether CI passes or not.

[x] Check CI is working
[ ] #175
[ ] #180
[x] Move CI to Zestylogic/fmark
[ ] Review the reasons for the 4 ignored tests
[ ] Maybe reintroduce parallelism in testing (recall disabling it because it broke our tests for some reason, probably a bug in a library that is fixed now?)

ymherklotz commented 5 years ago

CI is working: https://travis-ci.org/ymherklotz/FMark

We just need to add a test that parses a 10000 line markdown file for example, hopefully under 1sec.

ps-george commented 4 years ago

Do we test the bundled .js output?

ps-george commented 4 years ago

Does CI still work after switching repo? Is it still at /ymherklotz/FMark? @ymherklotz any plan to move it to zestylogic/FMark or is it all good to leave it where it is?

ymherklotz commented 4 years ago

Just moved it to https://travis-ci.org/Zestylogic/FMark. Going to fix it in the documentation.

ps-george commented 4 years ago

What was the reason that we ignored these 4 tests? Time?

Maybe they will be okay to include after #175 is merged and #179 is done?

ymherklotz commented 4 years ago

One of them is one of mine, which is a broken property test, don't know about the others.