search

Zetawar / zetawar

Zetawar is a turn based tactical strategy game implemented in 100% ClojureScript.
MIT License
169 stars 14 forks source link

Add air units and mobile flak unit #101

Closed tbeddy closed 6 years ago

tbeddy commented 6 years ago

Closes #83

This PR builds off #87, mostly just adding the data and assets for four more units (bomber, fighter, gunship, mobile flak) and a base-type (airfield).

When adding the stats table to the unit-picker modal, I decided to use the first letter of each armor-type to conserve space. However, now that "Air" joins "Armored," I decided to change their shortened forms to "Ai" and "Ar," respectively. I don't think this looks very good and it should probably be changed, but I'm not sure to what.

tbeddy commented 6 years ago

@djwhitt Feedback?

djwhitt commented 6 years ago

Sorry for sitting on this one so long. I'll take a look in the next few days.

tbeddy commented 6 years ago

Would changing any of the unit-type names (personnel, armored, naval, air) be a bad idea? I'm not very familiar with war-game terminology and don't know if that would break with standard naming conventions. If it does, I'd rather just keep "Ai" and "Ar."

djwhitt commented 6 years ago

I'd say leave the unit type names for now. The abbreviations aren't ideal, but I think what we really want is a different unit picker design. The giant table is a getting a bit unwieldy.