Add support for units that can repair other units

[djwhitt]

This one is a little involved. To do this you need to:

• [x] Add can-repair (set of armor types) for units types (loaded in unit-types-tx).
• [x] Add repair-other action to :move-attack unit state map.
• [x] Add a unit type that can repair other units (see Elite Command medic).
• [x] Add a function to check if a unit can repair another unit (see check-can-repair).
• [x] Add a function to execute a repair transaction (see repair-tx).
• [x] Add a case to action-tx.
• [x] Add a 'sub' to check whether the currently selected unit can repair the currently selected target (see can-repair? and selected-can-repair?).
• [x] Add a UI event (see repair-selected even handler).
• [x] Add a button for repairing a targeted unit (see faction-actions).

I suggest we call the action :action.type/repair-other-unit and the event :zetawar.ui.events/repair-targeted.

[tbeddy]

I'm interested in working on this.

[djwhitt]

Glad you're tackling this! I'd say keep it inline with repair. I'll write up some more general notes on this tomorrow too.

On Wed, Mar 1, 2017 at 5:30 PM, tcmb notifications@github.com wrote:

Would you prefer that repairing other units be called something distinct like "heal" or keep it in line with "repair?" I just started digging into the code and wanted to know what you were envisioning.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Zetawar/zetawar/issues/43#issuecomment-283506259, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAEVsJ2FsBdJ6Hn-6QEu_MrUlv38eMxks5rhf-jgaJpZM4LiMSp .

[tbeddy]

Cool, looking forward to it.

[djwhitt]

I added some tasks to the description to point you in the right direction. It's possible I missed something, but I think that list is pretty complete. I realize it's quite a bit to absorb. Adding a new action to the game is one of the more involved changes you can make. Don't panic though. Just take them one at a time and I'm sure you can get through it. Feel free to ask questions or request code reviews as you go. Good luck!

[tbeddy]

Thanks for the description. Should I make the medic images from the elite-command repo? Edit: I made the medic images and they seem fine.

[tbeddy]

There are some bugs, but I have a version of the feature and I'd appreciate your feedback. Would you like to do it through a pull request or just check my repo?

[djwhitt]

Nice! A pull request sounds good. That way I can add comments and such.

[tbeddy]

I added a couple of commits to my pull request. Sorry for any possible confusion.

[djwhitt]

No worries. I'm busy today, but I'll take look tomorrow and give you some feedback.

On Mar 4, 2017 11:44 PM, "tcmb" notifications@github.com wrote:

I added a couple of commits to my pull request. Sorry for any possible confusion.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Zetawar/zetawar/issues/43#issuecomment-284198900, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAEVmPmw0lDYXSlDuNRPJm-bQlY8eTFks5rihVrgaJpZM4LiMSp .

[tbeddy]

This issue should probably be closed now.