tbeddy commented 7 years ago

67

The transport unit can carry personnel and armored units across bodies of water. See its definition in Elite Command: https://github.com/cvincent/elite-command/blob/c84a3afb3eb2aad3b88c9cc34a7c497caa156010/config/initializers/unit_definitions.rb#L1147

tbeddy commented 7 years ago

@djwhitt I had a lot of questions, so I'm consolidating them into this post.

If a player wants to load an infantry unit into a transport unit, should the infantry be selected and the transport unit targeted? Is the action being done by the infantry?
Should a transport unit be allowed to move the same turn that units have been loaded into it?
Should a unit only be able to load into a transport unit if the transport unit is one tile away?
Should a unit only be able to load into a transport unit if the transport unit is in a port?
Should the transport cost for each unit type be put into a map somewhere in the data file, such as :transport-costs {:personnel 1 :armored 3} or should it be hardcoded into each unit definition (the same way only personnel can capture but that information is represented as a bool within every unit definition)?
When a unit is loaded into a transport unit, what should happen to its representation in the database? It could be retracted, all of its relevant information (unit-type, round-built, count) stored within the transport unit's data, and re-added when it leaves the transport unit. If a transport unit is destroyed, all of its passengers would automatically go down too (which I imagine is the intended behavior). But I don't know what issues this could cause or if it's unidiomatic.

djwhitt commented 7 years ago

Yep, infantry selected and transport targeted. Infantry should perform the boarding action.
Yes.
As long as the transport is within movement range, it should be possible to board it.
No, loading anywhere along the shore should be allowed.
By cost do you mean the space occupied inside the transport? If so, then it should be part of each unit definition. It'll likely be the same for all personnel, but I could see it varying for armored units.
There should be a unit/units-contained attribute on the transport. When a unit boards, it should get related to the transport using that attribute, and its location should be retracted. When the unit deboards, the transports unit/units-contained attribute should be retracted and the new location should be added to the unit.

tbeddy commented 7 years ago

Thanks for these answers. Follow ups:

3/4. I'm having a bit of trouble determining when a passenger unit can board a transport unit, if the transport unit is on a terrain the passenger unit cannot move to. It might be better for me to leave it unfixed for now and we can look more closely at the code together when I make a PR.

Yeah, cost = space occupied. Elite Command gave personnel a cost of 1 and armored a cost of 3. For now, I've assigned 1 to all personnel and 3 to all armored, naval, and air (in their unit defs).

And some new questions: Whenever a unit with units contained is selected, I imagine information about each of those contained units should be displayed. I'm thinking it could either appear below the screen (above or below the hover/terrain-effects info) or a button could appear (labeled something like "View units contained") that would trigger a modal with the same information (probably in a nicer, less compact format like the unit picker, with corresponding images for each unit).

Which option seems better to you? Or do you have another idea entirely?
What information should be displayed? I think only unit-type and count matter since the unit can't really do anything while being transported.

djwhitt commented 7 years ago

3/4. Ah, I hadn't fully thought through the implications of not being able to move to the terrain the transport is on. Pressing on sounds good and I'll keep thinking about it.

Re viewing contained units, I was thinking about this a bit when you asked your previous set of questions and wondered what your plan was. :smile:

I think a "View units contained" (or something similar) button + modal popup is the better option. I don't love either choice, but I haven't thought of anything better. I agree about the information displayed. Unit type and count are all that's needed.

tbeddy commented 7 years ago

Cool, I was also thinking the button + modal popup would be better so I'll get that working soon. We can always replace it later if someone thinks of a better design.