search

ZettaIO / cachet-client

A python 3.6+ client for the Cachet API : https://cachet-client.readthedocs.io/
MIT License
14 stars 8 forks source link

fix: fix various typos #10

Closed ccampo133 closed 4 years ago

ccampo133 commented 4 years ago

I noticed quite a few typos in the repository, so I've corrected them in this PR. Unfortunately, two of the main classes (CompontentGroup and CompontentGroupManager) were misspelled, so renaming them to correct the spelling is a breaking change for existing users and hence requires a major version bump. I included the version bump in this PR.

einarf commented 4 years ago

Wow. That was a lot of typos 😄

Major bump is more than ok. Probably need up update tests and get that visible flag in.. and 2.0 should be quick to sort out.

einarf commented 4 years ago

Thank you again!

ccampo133 commented 4 years ago

No problem. Regarding the visible flag, I'll have a PR for that shortly.

einarf commented 4 years ago

At least I managed to spell Component correctly in the class 😄

I'll keep my eyes open for the PR. Should be more than reasonable to push a 2.0 to PyPI in a few.