Fix Internal Server Error when creating incident

ZettaIO / cachet-client

A python 3.6+ client for the Cachet API : https://cachet-client.readthedocs.io/

MIT License

14 stars 8 forks source link

Fix Internal Server Error when creating incident #14

Closed sbag13 closed 4 years ago

sbag13 commented 4 years ago

Cached requires template_vars while incident creation to be list

einarf commented 4 years ago

It this something specific to 2.4? I did not see this in 2.3.x.

einarf commented 4 years ago

I'll accept this for now and compare with 2.3.x

einarf commented 4 years ago

Moved the test down to the dict creation instead. That way passing template_vars=None will also avoid 500 error and we avoid using mutable types as the default value.

'vars': template_vars or []

einarf commented 4 years ago

2.0.1 is now on PyPI