search

ZettaIO / cachet-client

A python 3.6+ client for the Cachet API : https://cachet-client.readthedocs.io/
MIT License
14 stars 8 forks source link

add schedules #19

Closed neutron-ah closed 4 years ago

einarf commented 4 years ago

Thanks! I will look at this very soon.

einarf commented 4 years ago

Thanks. Just merging this as I'm working with tests.

neutron-ah commented 4 years ago

Thank! Are you planning to upgrade the pypi package?

einarf commented 4 years ago

Yup. Doing some other maintenance and a new version will be pushed. Likely tonight.

neutron-ah commented 4 years ago

Schedule can create only in datetime format without seconds: scheduled_at=datetime.datetime.now().strftime('%Y-%m-%d %H:%M'))

einarf commented 4 years ago

Yup. I noticed in cachet logs. There was a missing completed_at in create and some other smaller stuff like docstrings. Also added unit and live tests.

3.1.0 should be on pypi now.

neutron-ah commented 4 years ago

There is cachet bug in schedules – when completed_at is set then no Maintaince object is displayed on main page.

einarf commented 4 years ago

ah right. Still the api supports setting it, so we are fine on this side.

The only confusing thing is the components parameter it supports. You can pass in a list of components the maintenance event affects, but nothing is displayed in cachet web. I was unsure if it actually had any function and left it out for now.

When I think of it.. it might affect the notify parameter triggering notification to users subscribed to the affected components.

We do at least have a decent start on supporting schedules :+1:

einarf commented 4 years ago

Everything working ok with new version?

neutron-ah commented 4 years ago

Yes, everything is great. Thanks a lot for your project!