ZettaScaleLabs / stabby

A Stable ABI for Rust with compact sum-types

Other

317 stars 12 forks source link

use 1.78.0 workaround for <1.78.0 #72

Closed yellowhatter closed 3 months ago

yellowhatter commented 3 months ago

EXTREME NOPE

The 1.78 workaround is all around horrible. I'll investigate why there's apparently an issue with 1.73, but no way am I making leaking v-tables to the heap the default for any compiler version that supports anything else.

I see all the ugliness of 1.78 solution, I just think that not supporting lower versions is worse than supporting them with a horrible workaround for a while :)

yellowhatter commented 3 months ago

The problem is not only 1.73, 1.75 or 1.76 is also affected

p-avital commented 3 months ago

Closing in favour of #73: the MSRV regression was caused by artifacts of the 1.78 workaround seeping in the pre-1.78 implementation.

73 fixes the regression by ensure correct code is generated for pre-1.78 and adds new safeguards to avoid this happening again.