Update GitHub Actions Workflows

Zettelkasten-Team / Zettelkasten

Zettelkasten-Developer-Builds

http://zettelkasten.danielluedecke.de

GNU General Public License v3.0

735 stars 94 forks source link

Update GitHub Actions Workflows #273

Closed RalfBarkow closed 2 years ago

RalfBarkow commented 4 years ago

Hi @RalfBarkow, sorry for the late response and my abscence lately. I will test the java 8 build this weekend and will check what the error is and whether it is fixable. I really think we should push the bundling of the jre into the zettelkasten further. Then the user does not have to care about the installation of the JRE anymore.

Originally posted by @Elmari in https://github.com/sjPlot/Zettelkasten/issues/266#issuecomment-679851175

Elmari commented 4 years ago

Ah, forgot about that, sorry. Now I am on vacation. I will check that as soon as I am back.

RalfBarkow commented 4 years ago

I started over from scratch in master branch @ RalfBarkow / Zettelkasten

See documentation Building and testing Java with Maven
fae24b4 Create java-ci-with-maven.yml
425a40f Delete old tests as Workflow: Java CI with Maven run failed
41934dd pom.xml: Remove appbundler (as the image ubuntu-latest doesn't have the genisoimage tool preinstalled, so build failed to execute goal sh.tak.appbundler:appbundle-maven-plugin:1.2.0:bundle
- See Feature/mac builds with macosappbundler #201
- @Elmari 3dc8995 added the mac os app bundler by perdian as a replacement for appbundler-1.0.

RalfBarkow commented 4 years ago

What do I want to achieve?

Do not interfere with the existing maven.yml workflow
Doesn't want to have to work with prereleases anymore, for example to provide the current status of pt_BR localization.

Elmari commented 4 years ago

@RalfBarkow i don't quite understand your last point. You don't have to work with prereleases, Releases can be built automatically as well.

RalfBarkow commented 4 years ago

@Elmari I don't quite understand your last point. You don't have to work with prereleases, Releases can be built automatically as well.

I would like to have a snapshot build after each push (or PR) to the development and/or a feature branch. I don't want to create a release (or pre-release) for every small change in the pt_BR build. I expect some more review cycles before pt_BR is ready for release.

Elmari commented 4 years ago

Ah okay, I see. Sounds good to me. Although I think we need another platform for those builds, right? What do you think?

RalfBarkow commented 4 years ago

@Elmari I think we need another platform for those builds, right?

Currently, see feature/Update_GitHub_Actions_Workflows, I'm using Ubuntu to build the .jar and .exe targets/package, and Mac OS X to build .dmg package.

Elmari commented 4 years ago

@RalfBarkow I meant for storing the nightlies / snapshots.

RalfBarkow commented 4 years ago

@Elmari I meant for storing the nightlies / snapshots.

Yes, good idea. Currently the generated artefacts could be downloaded from https://github.com/sjPlot/Zettelkasten/actions

RalfBarkow commented 4 years ago

Public read access to Actions artifacts ?

RalfBarkow commented 4 years ago

See Project Update GitHub Actions Workflows for this issue.

Elmari commented 4 years ago

@Elmari I meant for storing the nightlies / snapshots.

Yes, good idea. Currently the generated artefacts could be downloaded from https://github.com/sjPlot/Zettelkasten/actions

Ah i see, didn't know about that.