search

Zettelkasten-Team / Zettelkasten

Zettelkasten-Developer-Builds
http://zettelkasten.danielluedecke.de
GNU General Public License v3.0
735 stars 94 forks source link

English language version - Untranslated German items #375

Closed Der-Alte-Fritz closed 3 years ago

Der-Alte-Fritz commented 3 years ago

Describe the bug Parts of the English language version of the programme show elements in German. 1) exporting sub-menu

To Reproduce File / Export / Sub-menu opens

Expected behavior

Screenshots attached Screenshot (1743)_LI

Version information (please complete the following information):

Log information

Additional context

Der-Alte-Fritz commented 3 years ago

Another one in the Import sub-menu Screenshot (1748)_LI

Der-Alte-Fritz commented 3 years ago

Another one in Preferences / Tables and List Views Screenshot (1778)_LI

trutzig89182 commented 3 years ago

I could try to add some translations. Should they still be pushed to v3.2.8, @RalfBarkow? Then I would fork that version.

buhtz commented 3 years ago

Dear maintainers, because I am also interested in contributing (e.g. translating) can you please add the information's about how to pull request (e.g. again which branch), how to translate and any other information you think an external contributor should know.

trutzig89182 commented 3 years ago

Couldn’t find the variable for the hover-over text from the import sub-menu, but the translations for the other two cases.

https://github.com/Zettelkasten-Team/Zettelkasten/blob/648658f92cc9c753d9eb7f30667271cf14237459/src/main/resources/de/danielluedecke/zettelkasten/resources/CSettingsDlg_en_GB.properties#L238

https://github.com/Zettelkasten-Team/Zettelkasten/blob/648658f92cc9c753d9eb7f30667271cf14237459/src/main/resources/de/danielluedecke/zettelkasten/resources/CExport_en_GB.properties#L64

I stumbled over a strange line in the first file. No variable is given and I could not find a corrsesponding variable in the german source file. https://github.com/Zettelkasten-Team/Zettelkasten/blob/648658f92cc9c753d9eb7f30667271cf14237459/src/main/resources/de/danielluedecke/zettelkasten/resources/CSettingsDlg_en_GB.properties#L228

RalfBarkow commented 3 years ago

@Der-Alte-Fritz and @trutzig89182 Please check the actual build for release/v3.2.8, that I am currently working on.

The missing translations should already be fixed in it. If not, then we can work them in there. (I don't plan any bugfixes for v3.3.1 at the moment, but suggest to finish a v.3.2.8 first and on this basis develop the 3.3.x branch further).

See actual build at https://github.com/Zettelkasten-Team/Zettelkasten/actions/runs/1391137977

Der-Alte-Fritz commented 3 years ago

@RalfBarkow have checked my Zkn3 version and I am using Zettelkasten 3.3.1 (Build 78d6775) and this is the one that contains the German language elements. I will download and check 3.2.8

Der-Alte-Fritz commented 3 years ago

@RalfBarkow I have checked 3.2.8 and there are still a couple of problems

  1. A new German term has appeared on File menu - "Beenden" Ctrl+Q
  2. The German term in Preferences/Tables has been removed but nothing has replaced it, so it is just a blank box and then the button.
  3. Import item fixed
  4. Export item fixed
RalfBarkow commented 3 years ago

Thanks @Der-Alte-Fritz for testing the current build of the upcoming version 3.2.8 and giving feedback.

RalfBarkow commented 3 years ago

@Codeberg-AsGithubAlternative-buhtz

… interested in contributing (e.g. translating) …

You are welcome! See e.g. https://www.jetbrains.com/help/idea/internationalization-and-localization.html for how to install Resource Bundle Editor and Editing resource bundles.

RalfBarkow commented 3 years ago

@Der-Alte-Fritz File menu - "Beenden" Ctrl+Q is fixed. Next: CSettingsDlg > Tables and Listviews

RalfBarkow commented 3 years ago

In CSettingsDlg.form, the label jLabelFontDeskLayout.text=Schriftart Schreibtischgliederung: is missing.

RalfBarkow commented 3 years ago

@Der-Alte-Fritz The German term in the settings/tables should now also be fixed. See current build at https://github.com/Zettelkasten-Team/Zettelkasten/actions/runs/1405069185

RalfBarkow commented 3 years ago

@trutzig89182

I could try to add some translations. Should they still be pushed to v3.2.8, @RalfBarkow? Then I would fork that version.

You're welcome to do it that way. release/v3.2.8 is my current main branch. (Maybe we should rename the master branch; I'd like to switch to trunk-based development.)

Der-Alte-Fritz commented 3 years ago

@Der-Alte-Fritz The German term in the settings/tables should now also be fixed. See current build at https://github.com/Zettelkasten-Team/Zettelkasten/actions/runs/1405069185

OK

  1. File/Quit menu item is fixed.
  2. Other one in Preferences / Tables and List Views - text has reappeared but it is in German not English so still needs correcting. Sorry regards
RalfBarkow commented 3 years ago

@Der-Alte-Fritz Item 2. should be fixed in https://github.com/Zettelkasten-Team/Zettelkasten/actions/runs/1410132341

Bildschirmfoto 2021-11-02 um 00 55 04
RalfBarkow commented 3 years ago

I really don't enjoy having to work with Netbeans Visual Designer here, especially since the original author simply numbered the layout elements (for example, jLabel7, jLabel8, etc.). It's very hard for me to navigate around it and make changes.

RalfBarkow commented 3 years ago

BTW: Font size for edit-window: Is this correct? I feel, it should read "Font size for the edit window:".

RalfBarkow commented 3 years ago

Furthermore, the Settings / Preferences dialog seems to me to be somewhat inconsistent in that under Tables and List Views you can also change the font for the outliner and its size, as well as the font size of the editing window, although there is a Fonts and Colors tab for that. Maybe this is the reason why "Font Desk layout:" was deleted at some point. (The terminology was also changed to Outliner).

RalfBarkow commented 3 years ago

@Codeberg-AsGithubAlternative-buhtz

Dear maintainers, because I am also interested in contributing (e.g. translating) can you please add the information's about how to pull request (e.g. again which branch), how to translate and any other information you think an external contributor should know.

As requested I have added a CONTRIBUTING.md, see Commit 141c68b

But please don't be surprised that I have chosen to perhaps go a different way than you expect. My recommendation via CONTRIBUTING.md would be to read the text by Tudor Girba linked there:

GIRBA, Tudor, 2020. #remote, #nomeetings, #noestimation, #nobacklog. #storytelling. How we work at feenk. Medium [online]. 15 Mai 2020. [Accessed on: 1 July 2021]. Available at: https://medium.com/feenk/remote-nomeetings-noestimation-nobacklog-storytelling-d0d1b3b7a2de

Thank you

trutzig89182 commented 3 years ago

Thanks for the interesting read, @RalfBarkow. Couldn’t it be helpful anyway to mark a recommended version for contributions (as you don’t have to suggest using 3.2.8. each time someone wants to contribute and as it can safe some time for people who do not contribute on a regular basis and will likely produce a pull request for the master branch). This problem would, if I understand it correctly, be resolved if the Zettelkasten development changes to trunk based development, but it could still be useful in the meantime.

Also, speaking as a untalented autodidact I am, it would be great, if we could try to mark problems that are suitable for newcommers and people with limited skills like me. Of course I understand that there is a thin line here: I try to contribute with my limited skills but am aware that others are not responsible for helping me and that this should not end up being more work for them than doing things themselves. But the feenk example assumes a relatively fixed team of professionals and perhaps it could be good to create some inclusive opportunities beyond that in the Zettelkasten project?

So, I hope my story is somewhat convincing. ;)

RalfBarkow commented 3 years ago

@Der-Alte-Fritz I just want to let you know that in the main branch I changed the "Note Sequences" text in the menu and the tab to title case.