Zeugma440 / atldotnet

Fully managed, portable and easy-to-use C# library to read and edit audio data and metadata (tags) from various audio formats, playlists and CUE sheets
MIT License
459 stars 61 forks source link

Writing is not supported for OGG with embedded FLAC #206

Closed fsobolev closed 1 year ago

fsobolev commented 1 year ago

The problem

README states that writing to OGG with embedded FLAC is supported when it's actually not.

Environment

Details

Writing is not supported yet for embedded FLAC
   at ATL.AudioData.IO.Ogg.Write(Stream s, TagData tag, Action`1 writeProgress)
   at ATL.AudioData.AudioDataManager.UpdateTagInFile(TagData theTag, TagType tagType, ProgressManager writeProgress)

Code To Reproduce Issue [ Good To Have ]

$ dotnet new console
$ dotnet add package z440.atl.core --version 4.34.0

Program.cs

using ATL;
using System;

public class Program
{
    private static void Main(string[] args)
    {
        var track = new Track(args[0]);
        Console.WriteLine(track.Title);
        track.Title = "TEST";
        track.Save();
        Console.WriteLine(track.Title);
    }
}

If the opened file is OGG with embedded FLAC, the error mentioned above will appear and the data will not be written to the file.

Zeugma440 commented 1 year ago

Alright, obviously, the readme is incorrect, but I guess that's not what you really meant ;)

I'll see what I can do.

Zeugma440 commented 1 year ago

Fixed for next update ✅

Zeugma440 commented 1 year ago

Available on today's v4.35 \o/

Please close the issue if you confirm the fix on your side~

nlogozzo commented 1 year ago

Fixed on my system!!

@fsobolev will close when he confirms the fix on his side as well :)

fsobolev commented 1 year ago

Works as expected now, thanks :)