search

Zeugma440 / atldotnet

Fully managed, portable and easy-to-use C# library to read and edit audio data and metadata (tags) from various audio formats, playlists and CUE sheets
MIT License
459 stars 61 forks source link

Improve mapping between WAV and ATL frame codes #207

Closed fsobolev closed 1 year ago

fsobolev commented 1 year ago

In WAV files encoded with ffmpeg album and track number are saved to IPRD and IPRT respectively. I tried to find some information to figure out what else can be used in WAV, and found that track number can be saved to ITRK, so I added this too.

Zeugma440 commented 1 year ago

Fair enough 😄

Thanks for the PR !

Zeugma440 commented 1 year ago

Looks like some unit tests failed. I'll take a look at them once I'm back with Visual Studio.

No worries, it's probably internal clockwork that needs an adjustment.

fsobolev commented 1 year ago

Okay, thanks :)

Zeugma440 commented 1 year ago

Unit tests have been fixed - 9feabcd943935efd1e8666b00876a29f2500a983

fsobolev commented 1 year ago

Sorry, I'm absolutely not familiar with atldotnet code, just added these couple of lines and tested that tags was reading correctly, but I didn't check anything else 😅 Thanks for finishing everything that's needed!

Zeugma440 commented 1 year ago

Sorry, I'm absolutely not familiar with atldotnet code, just added these couple of lines and tested that tags was reading correctly, but I didn't check anything else 😅 Thanks for finishing everything that's needed!

No problem man. This would have 100% worked for other formats, but WAV and all its different chunks is a little trickier ;)