search

Zeugma440 / atldotnet

Fully managed, portable and easy-to-use C# library to read and edit audio data and metadata (tags) from various audio formats, playlists and CUE sheets
MIT License
440 stars 60 forks source link

Lyrics Language Code and Description Not Saving #220

Closed nlogozzo closed 10 months ago

nlogozzo commented 10 months ago

Hello again :)

It seems that LyricsInfo.LanguageCode and LyricsInfo.Description don't always save correctly. Here's a file for testing with blank unsync and sync: (Removed)

If I do:

var track = new Track(Path)
track.Lyrics.LanguageCode = "eng";
track.Save();

and then reload (track = new Track(Path)) the file, the LanguageCode was not saved.

If I do:

var track = new Track(Path)
track.Lyrics.Description = "xyz";
track.Save();

and then reload (track = new Track(Path)) the file, the Description was not saved.

If I do:

var track = new Track(Path)
track.Lyrics.LanguageCode = "eng";
track.Lyrics.Description = "xyz";
track.Lyrics.UnsynchronizedLyrics = "asd";
track.Save();

and then reload (track = new Track(Path)) the file, the language code and description are saved correctly. But shouldn't they still save without setting UnsyncrhonizedLyrics as they can also apply to SynchronizedLyrics?

Zeugma440 commented 10 months ago

I simply assumed setting a description or a language code without setting the lyrics themselves is pointless. Plus in ID3v2, language code and description cannot float in outer space - they need to be linked to other metadata.

But shouldn't they still save without setting UnsyncrhonizedLyrics as they can also apply to SynchronizedLyrics?

Of course - in that case, setting SynchronizedLyrics will save these fields too

nlogozzo commented 10 months ago

Ah ok yeah that makes sense. All good then.

nlogozzo commented 10 months ago

Good to release #219 then :)

Zeugma440 commented 10 months ago

To be honest, I don't like doing a release for every single change, unless there's something broken (which was the case until now).

Do you really need it right now, or do we have time to wait a little so that I can bundle other changes into the upcoming version?

nlogozzo commented 10 months ago

To be honest, I don't like doing a release for every single change, unless there's something broken (which was the case until now).

Do you really need it right now, or do we have time to wait a little so that I can bundle other changes into the upcoming version?

Yeah I get it...this one though I'd like now because it prevented me from seeing sync lyrics changes in Tagger ... but in the future I'm ok with waiting...just that I plan to release Tagger stable on Friday as well.

I truly appreciate all the work you've done and working closely with us to get all this fixed and out ❤️

Zeugma440 commented 10 months ago

Yeah I get it...this one though I'd like now because it prevented me from seeing sync lyrics changes in Tagger ... but in the future I'm ok with waiting...just that I plan to release Tagger stable on Friday as well.

Then could we wait until thursday to make sure you won't have any other issue in the meantime?

I truly appreciate all the work you've done and working closely with us to get all this fixed and out

My pleasure! All that you've found and suggested is now available for all ATL users, which is a genuine win-win situation 😄

nlogozzo commented 10 months ago

Then could we wait until thursday to make sure you won't have any other issue in the meantime?

Sure :)