search

Zeugma440 / atldotnet

Fully managed, portable and easy-to-use C# library to read and edit audio data and metadata (tags) from various audio formats, playlists and CUE sheets
MIT License
466 stars 63 forks source link

MP3 Title contains extra character starting in 5.04 #242

Closed seankearney closed 10 months ago

seankearney commented 11 months ago

The problem

The MP3's title field contains a trailing ' whereas v4.33 didn't return this. Mp3Tag & Windows Media Player don't show this character either. The tag editor by @nlogozzo (leveraging ATL) shows the character.

image

Environment

Details

I have an application currently using v4.33. In the process of updating to v5.13 we've detected a difference in one of our test files where ATL returns an extra character in the Title field. I've isolated this change as starting with commit https://github.com/Zeugma440/atldotnet/commit/0bc4513c9e8a52cd1b442446c143e709ff8ca8a3.

Code To Reproduce Issue [ Good To Have ]

I've emailed the sample file to @Zeugma440

Zeugma440 commented 11 months ago

I couldn't reproduce the issue on my side with the sample track you sent me. However, that sample track is "Good Days" whereas the track on your screenshot is "Soul With a Capital S". Did you upload the wrong one by any chance?

seankearney commented 11 months ago

Following up via email.

Zeugma440 commented 10 months ago

Thanks! It's been fixed for next release.

The title you saw with the ' at the end is actually the ID3v1 title, which has been used as a fallback because the ID3v2 title couldn't be read.

That latter issue was caused by a regression from 2d1685b333de5778a94bd2cfdbb6e9bf9b5f3207 where ID3v2 parsing stopped prematurely because of a malformed Comment field. Those are now properly ignored.

Zeugma440 commented 10 months ago

The fix is available in today's v5.14~

Please close the issue if you confirm it.

seankearney commented 10 months ago

Looks great! Closing. Thank you!!!