search

Zeugma440 / atldotnet

Fully managed, portable and easy-to-use C# library to read and edit audio data and metadata (tags) from various audio formats, playlists and CUE sheets
MIT License
460 stars 61 forks source link

Add support ENCODEDBY #245

Closed Agagamand closed 8 months ago

Agagamand commented 8 months ago

This tag is present in ID3v2: https://docs.mp3tag.de/mapping/ This tag automatically adds qaac.exe when converting to .m4a. It shows this program: https://github.com/Martchus/tageditor/

Zeugma440 commented 8 months ago

Done! Support will be available in next release.

Agagamand commented 8 months ago

Maybe at the same time add the ENCODERSETTINGS tag? I would use it. And WWWAUDIOSOURCE, ORIGYEAR, LYRICIST, LANGUAGE, ISRC, INVOLVEDPEOPLE

Zeugma440 commented 8 months ago

A few comments:

1/ ENCODEDBY should be used to store the name of someone or an organization who did the encoding. If you're looking to store the name of the software used to encode, you'd need the ENCODER metadata.

2/ WWWAUDIOSOURCE only exists in ID3v2 and thus is not standard among multiple tagging formats. I won't implement it as a property into IMetadata and you'll have to manage it using AdditionalFields

Agagamand commented 8 months ago

1/ ENCODEDBY should be used to store the name of someone or an organization who did the encoding. If you're looking to store the name of the software used to encode, you'd need the ENCODER metadata.

Thank you for the information. I really want to save the name of the software used to encode ... and encoding settings. I think this is important information.

WWWAUDIOSOURCE only exists in ID3v2

And ASF/Windows Media: https://docs.mp3tag.de/mapping/

But I do not insist on adding these tags, since in most cases I myself use the APEv2 (for .tak) and mp4 (for AAC) tags.

Agagamand commented 8 months ago

I found an interesting table: https://wiki.hydrogenaud.io/index.php?title=Tag_Mapping

Consider adding tags: CatalogNumber, RecordingDate

Zeugma440 commented 8 months ago

I found an interesting table: https://wiki.hydrogenaud.io/index.php?title=Tag_Mapping

That's my reference, actually đź‘Ť

Consider adding tags: CatalogNumber, RecordingDate

err... do you really need all of these or do you enjoy making me jump into a different hoop every six hour?

Agagamand commented 8 months ago

do you really need all of these

Yes. I have only listed what I will use. I add all known information about the track and album to the tags. The listed tags will not be enough for me, but I haven’t found any more standard tags that suit me.

Zeugma440 commented 8 months ago

All's available on today's v5.16

Please close the issue if you're okay with the changes

Zeugma440 commented 8 months ago

A few extra comments regarding what you asked for :