OptimFROG blind tags - Githubissues

Zeugma440 / atldotnet

Fully managed, portable and easy-to-use C# library to read and edit audio data and metadata (tags) from various audio formats, playlists and CUE sheets

MIT License

440 stars 60 forks source link

OptimFROG blind tags #249

Closed Agagamand closed 4 months ago

Agagamand commented 5 months ago

The problem

I copied the tags (CopyMetadataTo) from .tak to .ofr, but MP3Tag and foobar2000 don't see the tags in .ofr. Only Aimp does, but only partially.

I want that after copying tags to .ofr, all programs that support APEv2 tags can read them.

Environment

ATL version (or git revision) that exhibits the issue: 5.18.0
OS/version used to run ATL: Win10

Zeugma440 commented 5 months ago

Alright, thanks for your feedback. Talking about optimFROG is almost necromancy xD I'll see what I can do

Agagamand commented 5 months ago

OptimFROG still provides better compression. As long as it remains so, it cannot be considered obsolete.

The necromancy is to use something like "RKau lossless compressor", which is not the best at anything. But that didn't stop the ffmpeg team from adding its support in version 6.0.

Zeugma440 commented 4 months ago

Looks like there are multiple factors at play here :

When writing to an audio file without any metadata, ATL uses the Settings.DefaultTagsWhenNoMetadata property to determine which tag types it should write. Default value is { MetaDataIOFactory.TagType.ID3V2, MetaDataIOFactory.TagType.NATIVE}, which means ATL writes ID3v2 values to empty OFR files.

NB : "Native" means "any non-standard tagging system native to the audio format" such as what MP4/M4A and WMA use.

MP3tag seems to be unable to read ID3v2 data from OFR files. The latest foobar2000 OFR plugin does, though.
When changing the default settings to write APE tags on empty files, everything seems to work fine
```
Settings.DefaultTagsWhenNoMetadata = new[] { MetaDataIOFactory.TagType.APE };
```

Can you confirm that on your side?

Agagamand commented 4 months ago

I confirm.

It seems to me that it would be better if ATL would default to APEv2 for . ofr, so that no additional setting.

Zeugma440 commented 4 months ago

Great suggestion - I've just done that 😄

Now the default for Settings.DefaultTagsWhenNoMetadata is MetaDataIOFactory.TagType.RECOMMENDED, which adapts to every audio format. Recommendation for OFR is APE, of course.

Zeugma440 commented 4 months ago

Available in today's v5.19

Please close the issue if it works on your side~