search

Zeugma440 / atldotnet

Fully managed, portable and easy-to-use C# library to read and edit audio data and metadata (tags) from various audio formats, playlists and CUE sheets
MIT License
440 stars 60 forks source link

Is the System.Threading.Tasks.Extensions PackageReference needed? #251

Closed Numpsy closed 4 months ago

Numpsy commented 4 months ago

Just a thought whilst looking at some things - I don't think the System.Threading.Tasks.Extensions nuget package should be needed as it should be inbox in all the currently targeted TFMs?

On a related note, I'm unclear if the z440.atl.core NuGet package should have a dependency on the Zomp.SyncMethodGenerator NuGet package or if it should be a development only dependency, but I don't know exactly how that works so I 'm not sure.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f189d2e) 89.17% compared to head (374d7e1) 89.17%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #251 +/- ## ======================================= Coverage 89.17% 89.17% ======================================= Files 94 94 Lines 19170 19170 Branches 2820 2820 ======================================= Hits 17095 17095 Misses 1460 1460 Partials 615 615 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Zeugma440 commented 4 months ago

Thanks for pointing that out!

Regarding Zomp.SyncMethodGenerator, it is indeed a build-time dependency. I've adjusted the project file accordingly.

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Zeugma440 commented 4 months ago

Available in today's v5.20

Numpsy commented 4 months ago

Regarding Zomp.SyncMethodGenerator, it is indeed a build-time dependency. I've adjusted the project file accordingly.

FYI, the System.Threading.Tasks.Extensions dependency is gone now, but the NuGet listing is still showing Zomp.SyncMethodGenerator as a dependant package:

image

Zeugma440 commented 4 months ago

Since the change I made (4251d597462946b97599ad85082005d287acdb90), the dependency is flagged with exclude="Runtime,Build,Analyzers" in the generated nupkg file, which looks okay to me.

<dependency id="Zomp.SyncMethodGenerator" version="1.0.12" exclude="Runtime,Build,Analyzers" />

I have no idea how to remove it entirely from the published metadata. Do you?

Numpsy commented 4 months ago

I have no idea how to remove it entirely from the published metadata. Do you?

https://github.com/Zeugma440/atldotnet/pull/256 maybe?