search

Zeugma440 / atldotnet

Fully managed, portable and easy-to-use C# library to read and edit audio data and metadata (tags) from various audio formats, playlists and CUE sheets
MIT License
460 stars 61 forks source link

Set PrivateAssets=All on the Zomp.SyncMethodGenerator PackageReference #256

Closed Numpsy closed 7 months ago

Numpsy commented 7 months ago

Refs https://github.com/Zeugma440/atldotnet/pull/251#issuecomment-1956829532

It looks like there was an issue in the past where the Zomp.SyncMethodGenerator NuGet package itself wasn't marked as a DevelopmentDependency when it should have been - https://github.com/zompinc/sync-method-generator/issues/11.

If I add the current version of the package to a new project, it gets added as 

    <PackageReference Include="Zomp.SyncMethodGenerator" Version="1.3.6">
      <PrivateAssets>all</PrivateAssets>
      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
    </PackageReference>
sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e81cb19) 89.19% compared to head (959257f) 89.19%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #256 +/- ## ======================================= Coverage 89.19% 89.19% ======================================= Files 94 94 Lines 19193 19193 Branches 2822 2822 ======================================= Hits 17119 17119 Misses 1460 1460 Partials 614 614 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Zeugma440 commented 7 months ago

Thanks, let's give it a go!