search

Zeugwerk / Twinpack

Twinpack is a package manager for TwinCAT libraries with integration into the TwinCAT IDE. It enables the TwinCAT community to share their libraries and simplifies the continous integration of third-party components into TwinCAT projects.
https://twinpack.dev
GNU General Public License v3.0
51 stars 3 forks source link

[draft] Use file extension to determine library type #139

Closed dfreiberger closed 1 month ago

dfreiberger commented 1 month ago

See https://github.com/Zeugwerk/Twinpack/issues/138

This is a work-around since the library type is not currently implemented in NugetServer.

This PR is not complete because there are other places in the code that I did not change that still refer to the project configuration for the library type, such as https://github.com/Zeugwerk/Twinpack/blob/main/TwinpackShared/TwinpackUtils.cs#L558

iadonkey commented 1 month ago

solved a bit differently in https://github.com/Zeugwerk/Twinpack/commit/e9a243d02a7e4729f9734e96901db5b70bc00bdd

for Beckhoff Servers the compiled flag is always true now, for Nuget Servers Twinpack defaults to "not compiled", but checks if there is a "tp-compiled-library" tag present and then handles the package as a compiled one

Can't test it right now with a nuget server since I am kinda in the middle of something else, @seehma will send you the installer containing the fix. Alternatively you can

Note that the fix is in the release/1.0 branch and is cherry-picked to main, which is currently under heavy refactoring due to the command line features, which will come in the next release

Please confirm if it works as expected, then we'll add it as a 1.0.9 patch release to GitHub