search

Zeugwerk / Twinpack

Twinpack is a package manager for TwinCAT libraries with integration into the TwinCAT IDE. It enables the TwinCAT community to share their libraries and simplifies the continous integration of third-party components into TwinCAT projects.
https://twinpack.dev
GNU General Public License v3.0
52 stars 3 forks source link

Add references not working if library title != library name #80

Closed iadonkey closed 1 year ago

iadonkey commented 1 year ago

If library title != library name there is an exception when trying to add the library, happens for the package "TwinCAT Dynamic Collection"

@fisothemes thanks for sharing you library with Twinpack. Unfortunately at the moment Twinpack has a this bug, but we will try to fix it

iadonkey commented 1 year ago

The Title of the plcproj should be changed by Twinpack so that name = title, but for this libraries this didn't work for some reason

https://github.com/Zeugwerk/Twinpack/blob/102caec581be8be792b5628dc32b7554ad98c583/Twinpack/TwinpackUtils.cs#L99

maybe we should just get rid of this limitation all together and allow to use a library title that is different from the name of the plcproj file

fisothemes commented 1 year ago

I'll see if I can change the title on the project and upload an updated version. Thanks for opening Twinpack for everyone to use

iadonkey commented 1 year ago

No need to change the title, it will be fixed with the next patch release (version > 0.2.10). We can then have a title and a different name (see PR above)