ZeusLN / zeus

A mobile Bitcoin wallet fit for the gods. ⚡️ Est. 563345
https://ZeusLN.com
Other
979 stars 146 forks source link

Comma in "Amount to pay" number #1804

Open acronymy opened 10 months ago

acronymy commented 10 months ago

Describe the bug

When enetering a number with a comma in "Amount to pay", Zeus truncates amount once CONFIRM selected. This issue would arise if one was copying a sats amount from satsconverter.io for example.

Reproduce

Lightning Send Lightning payment request address 85,879 Amount to pay CONFIRM Next screen now shows 85 sats only.

Zeus version

v0.8.0

Node interface

LndHub

Network

Clearnet

Device

Pixel 4a

Device operating system

Android 13 GrapheneOS

Log output

No response

myxmaster commented 10 months ago

Yes, we can definitely improve UI here.

General thoughts: It depends on the currently configured app language how "," and "." should be interpreted, because some languages use "," as thousands separator and "." as decimal separator and some languages do it the other way round. In general a space char is the best option for thousands seperator, as this cannot be misinterpreted as decimal separator, but it still makes it easy to read thousands.

So, what about this (examples are in English with ","=thousands separator and "."=decimal separator):