lndhub payment hash is not correctly processed

myxmaster commented 10 months ago

Describe the bug

When using lndhub, in the sending lightning success screen, the payment hash is not displayed. The reason is that it is expected to be a string but actually is an object of type { data: number[], type: string }. This also leads to Zeus not displaying lnurl success action data.

I already started working on a fix but then noticed that users could lose notes then, because the payment hash of lndhub transactions would then be used as note key instead of the (fallback) preimage. So we also need to take care of this. There are multiple possible solutions:

Always look for stored notes using the payment hash AND the preimage. Since there are many places in the code from where notes are loaded, it might be a good idea to create some kind of facade for the EncryptedStorage that gets the payment hash and the preimage and checks both. Otherwise we would have to modify the loading everywhere.
Migrate the notes from preimages to payment hashes once. Since there might be people with a lot of transactions (and notes) it might be necessary to show a progress indicator while migrating. So this might be a lot work.

Reproduce

Send using Lightning and lndhub. In the success screen, there is no payment hash displayed. The payment hash is also not displayed in Activity.

ZEUS version

v0.8.0

Node interface

LndHub

Network

Clearnet

Device

Android Emulator Pixel 7 Pro

Device operating system

Android 14

Log output

No response

kaloudis commented 7 months ago

I believe https://github.com/ZeusLN/zeus/pull/1920 fully addressed this. Correct, @myxmaster?

myxmaster commented 7 months ago

Not fully, since the note issue is not addressed yet.

ZeusLN / zeus