search

ZeusWPI / Haldis

Haldis is your friendly neighbourhood servant. He exists so lazy fucks like you and me don't need to keep tabs of who is ordering what from where.
Other
13 stars 15 forks source link

Update config.example.py not to contain a hardcoded secret #223

Open TomNaessens opened 1 month ago

TomNaessens commented 1 month ago

Closes #222

FKD13 commented 1 month ago

Don't know if they are used for production, but the docker compose files should contain this variable as well? What default should we use there?

FHantke commented 1 month ago

Hi, thanks for addressing the issue. Regarding the compose file, I'd suggest using the option to show errors on missing variables: https://docs.docker.com/compose/compose-file/12-interpolation/

redfast00 commented 1 month ago

In prod, we use passenger, not docker, so we should be fine to merge & "deploy" this