search

ZeusWPI / MOZAIC

MOZAIC is the Massive Online Zeus Artificial Intelligence Competition platform
GNU Lesser General Public License v3.0
13 stars 6 forks source link

Restructure #238

Closed wschella closed 6 years ago

wschella commented 6 years ago

This pull request is pretty clearly described by the commit messages.

iasoon commented 6 years ago

Nice!

The only remark I have is that components are now split up according to the page they are used in. I don't think this is really the model we want, as it kind of discourages component reuse.

wschella commented 6 years ago

Agreed, but I didn't immediately see an alternative that did provide that reuse, mostly because the components now are split up by page cause that's how they're used. But 'bots', 'matches', etc, IMO provide enough generality regarding the name and semantics that reusable components could be place in there as well.

iasoon commented 6 years ago

Yes, you are right about that. An alternative might be to put containers where they are used - with the router. Something to keep in mind is that later on, we want to re-use most of these components in the website. Anyhow, this gets my seal of approval for now!