search

ZeusWPI / gamification

Gamification of Zeus member engagement. Replaced by gamification2
https://github.com/ZeusWPI/gamification2
MIT License
4 stars 5 forks source link

Fix for issue #30 and #33 #35

Open VandorpeDavid opened 9 years ago

VandorpeDavid commented 9 years ago

First time using ruby. Please do review, although these commits are minor changes.

TomNaessens commented 9 years ago

Minor remark: try not to mix style/indentation fixes in PR's with features as this obscures the actual feature implementation in the diff

VandorpeDavid commented 9 years ago

My IDE's autostyling (or w/e it's called) did that, and I didn't realise it until the changes were already made and I was about to commit my code.

VandorpeDavid commented 9 years ago

Above commit seems to fix #32 in my browser, but I have absolutely no clue why.

Procrat commented 8 years ago

I don't know how or why, but somehow this PR was overlooked and the issues got fixed in other commits. Your fix for #30 is a lot nicer though.

Do you want to rebase this? (Note that the code has been ported to Coffeescript in the meantime.) If you don't have time, I can fix this myself if you give me permission to your private repo or if I open up a new PR. Your call!