search

ZeusWPI / gamification

Gamification of Zeus member engagement. Replaced by gamification2
https://github.com/ZeusWPI/gamification2
MIT License
4 stars 5 forks source link

Tests interacting with external entities (such as Github) #79

Open TomNaessens opened 9 years ago

TomNaessens commented 9 years ago

With the issues with travis, environment variables and Github tokens, I am not sure if it is OK to interact with an external entity in our tests. See for example https://travis-ci.org/ZeusWPI/gamification/builds/78897689, where https://github.com/ZeusWPI/gamification/blob/master/spec/requests/webhooks_spec.rb#L24 and https://github.com/ZeusWPI/gamification/blob/master/spec/requests/webhooks_spec.rb#L28 fail.

Shouldn't this get stubbed to avoid so we aren't depended on external entities and our internet connection?

dv commented 9 years ago

I propose adding VCR which is the standard way to deal with this in Ruby projects.

iasoon commented 8 years ago

Are these tests not stubbed? They act on sample JSONS which are stored in the repository.

iasoon commented 8 years ago

You are right. This is probably due to the commiter resolving.