search

Zewo / Reflection

DEPRECATED
MIT License
599 stars 46 forks source link

Feature/carthage integration #4

Closed petropavel13 closed 8 years ago

codecov-io commented 8 years ago

Current coverage is 79.62% (diff: 100%)

Merging #4 into master will not change coverage

@@             master         #4   diff @@
==========================================
  Files            27         27          
  Lines           486        486          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            387        387          
  Misses           99         99          
  Partials          0          0

Powered by Codecov. Last update 2bc1a76...cdcb842

petropavel13 commented 8 years ago

I just created cross platform XCode project inspired by this article http://basememara.com/creating-cross-platform-swift-frameworks-ios-watchos-tvos-via-carthage-cocoapods/ This project contains targets and tests for all platforms.

Danappelxx commented 8 years ago

Thanks for the PR! Our workflow involves the use of the Swift Package Manager to generate Xcode projects (swift package generate-xcodeproj) rather than having one checked in the repository. For that reason alone, I'm not sure if merging this PR is a great idea.

All that said, the author of this library has an iOS-ready version (with Cocoapods/Carthage support) available on his github account here! I highly recommend you take a look.

petropavel13 commented 8 years ago

Hi! Thanks for comment! It's a good idea to use generate-xcodeproj. Didn't know about your workflow.

But iOS-ready version last update was 2 month ago (is Swift 3 (release version) ready? who knows..). Also, it looks like Allegro repository just copy-paste a part of code from this repo. @bradhilton, please, can you tell something about it?

There should be different solution. I know front-end platforms it's not your field of business, so I will keep my fork and close this PR.

bradhilton commented 8 years ago

Hi @petropavel13, Allegro is an older version of Reflection with CocoaPod support. I'm hoping to make Reflection available on all platforms, but that may be through another repo like Allegro, because Reflection is just for Zewo's purposes.