search

Zfinix / carrier_info

šŸ“± Carrier Info gets networkType, networkGeneration, mobileCountryCode, mobileCountryCode, e.t.c from both android and iOS devices.
MIT License
34 stars 48 forks source link

[Android] google play store rejection because of `Permission.sms` #29

Open aytunch opened 1 year ago

aytunch commented 1 year ago

Hi, I understand this plugin needs this permission but, isn't it the convention that we add it to the app's top level manifest file?

Requested permissions do not match core functionality of the app You declared Default SMS handler android.permission.READ_SMS

@Zfinix do you have any thoughts on this?

Zfinix commented 1 year ago

I know I know I have had time to rebuild and update it in so long

On Wed, 22 Mar 2023 at 2:50 PM, aytunc @.***> wrote:

Hi, I understand this plugin needs this permission but, isn't it the convention that we add it to the app's top level manifest file?

Requested permissions do not match core functionality of the app You declared Default SMS handler android.permission.READ_SMS

@Zfinix https://github.com/Zfinix do you have any thoughts on this?

ā€” Reply to this email directly, view it on GitHub https://github.com/Zfinix/carrier_info/issues/29, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGE3JSPES3KDCZR7Y7U7A4LW5L7QTANCNFSM6AAAAAAWD3DHCM . You are receiving this because you were mentioned.Message ID: @.***>

-- Chiziaruhoma O.

aytunch commented 1 year ago

Can I kindly have an ETA on this fix? Thanks for the quick reply

Zfinix commented 1 year ago

Iā€™d do my best to get the entire package refactored by Monday

On Wed, 22 Mar 2023 at 2:52 PM, aytunc @.***> wrote:

Can I kindly have an ETA on this fix? Thanks for the quick reply

ā€” Reply to this email directly, view it on GitHub https://github.com/Zfinix/carrier_info/issues/29#issuecomment-1479606465, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGE3JSIOCP5TDUIESQF2PYTW5L7ZVANCNFSM6AAAAAAWD3DHCM . You are receiving this because you were mentioned.Message ID: @.***>

-- Chiziaruhoma O.

aytunch commented 1 year ago

Thank you very much. Have a good week

crushman1 commented 1 year ago

Hello, any updates on this ?

kattaliraees commented 1 year ago

in /android/app/src/main/AndroidManifest.xml add the below line if you want remove READ_SMS from the final merged Manifest file

<uses-permission android:name="android.permission.READ_SMS" tools:node="remove"/>