ZhangGe6 / onnx-modifier

A tool to modify ONNX models in a visualization fashion, based on Netron and Flask.
MIT License
1.33k stars 165 forks source link

Cannot always add outputs #57

Closed mcusgithub closed 1 year ago

mcusgithub commented 1 year ago

Sometimes, output(s) cannot be added / saved.

To reproduce:

This happens with other models (without deleting the output first as above; this is just to show how to reproduce the issue). It seems to happen when the selected node is a 'leaf' = last one on a branch.

Thank you for your help.

mcusgithub commented 1 year ago
ZhangGe6 commented 1 year ago

@mcusgithub Thanks for reporting! The problem has been reproduced and I will try to fix it soon.

WangFengtu1996 commented 1 year ago
ZhangGe6 commented 1 year ago

@WangFengtu1996 谢谢反馈,该问题可能和#72 原因相同。请使用最新代码,看看问题是否还存在。同时也可查看终端,显示的报错信息,可以帮助定位问题。

ZhangGe6 commented 1 year ago

@mcusgithub Hello, I have updated the code to fix the adding output issue (after a very long delay :sweat_smile:). You can update the code to the latest version, and see whether it works.

ZhangGe6 commented 1 year ago

This issue is going to be closed due to inactivity. Free free for more discussions if problems still exist.

mcusgithub commented 1 year ago

@ZhangGe6 Does not seem to work still (tested on YOLOv8n), and the initial workaround does not work anymore.

ZhangGe6 commented 1 year ago

@mcusgithub Thanks for reporting. As discussed in #75, with the latest code, the "adding output" function should be more robust than before. I have tested both the squeezenet and YOLOv8n. Adding output for both models works as expected.