search

ZhangGe6 / onnx-modifier

A tool to modify ONNX models in a visualization fashion, based on Netron and Flask.
MIT License
1.28k stars 157 forks source link

[flake8] app.py #99

Closed Lewis-Lu closed 5 months ago

Lewis-Lu commented 5 months ago
  1. make code style align to flake8
  2. avoid Bare except in Line 23.

Let me start this as the first contribution to the project. I'm adding a new feature to the tool.

ZhangGe6 commented 5 months ago

Merged. Thanks for your contribution and looking forward to the "new feature". BTW, can you introduce the new feature briefly?

Lewis-Lu commented 5 months ago

I don't know if it works, but the following is what I'm doing for the tool:

  1. study and fix the bug encountered during the delete&add ops ;
  2. add two graphs merge features.
  3. some customized operations, sounds weird, initializer/input conversion, for my own purpose;
ZhangGe6 commented 5 months ago

study and fix the bug encountered during the delete&add ops ;

Bugs are indeed old friends of onnx-modifier. If you feel weird about the codes or behaviors, feel free to create issues.

add two graphs merge features.

Excellent! This is exactly what issue#63 calls for.

some customized operations, sounds weird, initializer/input conversion, for my own purpose;

It is welcome to share these features. Of course you can keep it in the local branch.

Lewis-Lu commented 5 months ago

study and fix the bug encountered during the delete&add ops ;

Bugs are indeed old friends of onnx-modifier. If you feel weird about the codes or behaviors, feel free to create issues.

Sure, I would provide the steps for reproduce, and hopefully the PR for this in this week. :D

add two graphs merge features.

Excellent! This is exactly what issue#63 calls for.

some customized operations, sounds weird, initializer/input conversion, for my own purpose;

It is welcome to share these features. Of course you can keep it in the local branch.