ZhangJiaQiao / 2019-DBMS-Project

This is the programmin project of DBMS course in 2019
19 stars 26 forks source link

关于test #25

Closed Walikrence closed 5 years ago

Walikrence commented 5 years ago

在fptree_test.cpp中

TEST(FPTreeTest, SingleInsert) {
    FPTree* tree = new FPTree(2);
    tree->insert(1, 100);
    LeafNode* leaf = (LeafNode*)(tree->getRoot()->getChild(0));
    EXPECT_NE(nullptr, leaf);
    if (!leaf) {
        return;
    }
    EXPECT_EQ(leaf->find(1), 100);
    EXPECT_EQ(leaf->getPPointer().fileId, 1);
    EXPECT_EQ(leaf->getPPointer().offset, LEAF_GROUP_HEAD + calLeafSize() * (LEAF_GROUP_AMOUNT - 1));
    LeafNode* t_leaf = new LeafNode(leaf->getPPointer(), NULL);
    EXPECT_EQ(t_leaf->getBit(0), 1);
    EXPECT_EQ(t_leaf->find(1), 100);
    removeFile();
}

为什么TA用

    EXPECT_NE(nullptr, leaf);
    if (!leaf) {
        return;
    }

而不是用

ASSERT_NE(nullptr,leaf);

我想问下这样写的好处是什么,

(没错,我就是杠精

huanghongxun commented 5 years ago

我觉得只是 TA 不知道有这种用法吧。。

ZhangJiaQiao commented 5 years ago

上面同学说的对,因为我也只是本着能用就行的做法去实现的,可能还没有你们自己学习后知道的多