Uppercase files extensions

ZhangJian1713 / vscode-image-viewer

MIT License

17 stars 6 forks source link

Uppercase files extensions #21

Closed ews-ffarella closed 6 months ago

ews-ffarella commented 6 months ago

I think it would be great to:

Either add an option to modify showImageTypes as an extension option
and / or at least at the uppercase version of some extensions like 'JPG', 'JPEG', 'PNG', etc ...

Anyways, great extension 😃

ZhangJian1713 commented 6 months ago

I didn't quite get the meaning of request-1. Could you please elaborate further? As for request-2, I'll fix and update it ASAP.

ews-ffarella commented 6 months ago

The first comment was that maybe one could configure the file extensions that should be discovered. As an option. And thanks for considering the second possibility ;)

ZhangJian1713 commented 6 months ago

I have fixed support for uppercase image file extensions.

ZhangJian1713 commented 6 months ago

The first comment was that maybe one could configure the file extensions that should be discovered. As an option. And thanks for considering the second possibility ;)

I've tried to include all supported image types so users don't have to concern about it. Currently I have no plans to introduce a way for users to manually input this.

The supported image types now include: export const SUPPORT_IMG_TYPES = ['.svg', '.png', '.jpeg', '.jpg', '.ico', '.gif', '.webp', '.bmp', '.tif', '.tiff', '.apng', '.avif']