ZhangShiyue / QGforQA

MIT License
96 stars 19 forks source link

Saving best model based on which metric? #6

Closed ehsan-soe closed 4 years ago

ehsan-soe commented 4 years ago

Hi Shiyue,

Thanks for the nice job. I realized from your code that for each checkpoint you are saving the best model based on BLEU score on validation set. Is that right? Just wanted double check what is the metric you used to save the best model? BLEU or your own reward scores?

Thanks

ZhangShiyue commented 4 years ago

Yes, you are right. I save the best model based on the BLEU score.