search

ZhangWenyue3325 / pe

0 stars 0 forks source link

Hard to understand command input #3

Open ZhangWenyue3325 opened 4 months ago

ZhangWenyue3325 commented 4 months ago

image.png The -rep is how many times to take the medication. However, what the frequency is based on is not specified. It is based on one day, one week, or in total? The maximum time is 7 which is confusing - where does the seven come from?

nus-pe-script commented 4 months ago

Team's Response

To be updated.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unclear inputs for "rep" in add command

In the add command, you can say how many times to repeat the medication using the 'rep' input. In the UG it is unclear if this means to repeat in a week or something else. ( In this case, I am assuming it means how many times to repeat in a week based on the input being a number from 1-7). However, after you specify the numbers of times to take the medication per week, it does not allow you to say which days you want to take the medication. Thus, when you use the function list to check the medications you have to take for the day, it will give you all the medications in the list . This could be dangerous as perhaps you only have to take the medication on certain days, but could be consuming it wrongly

image.png

image.png

image.png

[original: nus-cs2113-AY2324S2/pe-interim#1413] [original labels: type.FunctionalityBug severity.High]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for pointing out this bug.

Each medication is added to the today list on the day that it was added into MediTracker, but for the daily list on subsequent days, the list is dictated by the corresponding repeat value.

I agree, the UG can be clearer, so this should at least be a DocumentationBug, to specify that 1 to 7 represents the number of days in a week. As this repeat does not hinder other functionality of the program, I have changed the severity from High to Low.

We can consider a future implementation to allow user to specify the day that they will start taking a medication, as currently, it is assumed that the user starts taking the medication on the day that it was added into MediTracker.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]