search

ZhangWenyue3325 / pe

0 stars 0 forks source link

Modification that is meaningless is also considered as successful #8

Open ZhangWenyue3325 opened 4 months ago

ZhangWenyue3325 commented 4 months ago

image.png

Same modification is allowed for more than one time for one medification.

nus-se-bot commented 4 months ago

Team's Response

Thank you for finding this flaw. Indeed, the medicine name should not be able to be modified to a name that is existing.

This issue has been marked as a duplicate of #1338 as they both mention the same issue of modifying the medication name to one that exists already.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Medicine can be modified to the same information

image.png When adding medicine, the same medicine is not allowed to be added more than one time. However, the medicine can be modified to the same name without any warnings.

image.png Actually all information can be modified to the same.

[original: nus-cs2113-AY2324S2/pe-interim#1194] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for finding this flaw. Indeed, the medicine name should not be able to be modified to a name that is existing.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: Thank you for your response. However, I believe that this issue is not duplicated. The #1338 means that two medicine can be modified to the same name but medicine with same name cannot be added twice. This issue refers that same modification can be successfully made for more than one times to one medicine, which is meaningless.

## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Medium`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]